HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33540
Change subject: src/security/vboot: Remove useless 'const' ......................................................................
src/security/vboot: Remove useless 'const'
Change-Id: I3b5ca272abffe46c6a63251cf4905780f87a6836 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/misc.h 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/33540/1
diff --git a/src/security/vboot/misc.h b/src/security/vboot/misc.h index acb6dbb..725f5fd 100644 --- a/src/security/vboot/misc.h +++ b/src/security/vboot/misc.h @@ -53,7 +53,7 @@ /* * Source: security/vboot/common.c */ -struct vboot_working_data * const vboot_get_working_data(void); +struct vboot_working_data *vboot_get_working_data(void); void vboot_init_work_context(struct vb2_context *ctx); void vboot_finalize_work_context(struct vb2_context *ctx); struct vb2_shared_data *vboot_get_shared_data(void);
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: src/security/vboot: Remove useless 'const' ......................................................................
Patch Set 1: Code-Review+1
The relevant 'const' was introduced here: https://review.coreboot.org/c/coreboot/+/8881/ See file: src/vendorcode/google/chromeos/chromeos.c
No reason was specified as to what it is for.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: src/security/vboot: Remove useless 'const' ......................................................................
Patch Set 1: Code-Review-1
(1 comment)
https://review.coreboot.org/#/c/33540/1/src/security/vboot/misc.h File src/security/vboot/misc.h:
https://review.coreboot.org/#/c/33540/1/src/security/vboot/misc.h@54 PS1, Line 54: * Source: security/vboot/common.c Have you checked that file? There's a function definition there as well!
Hello Aaron Durbin, Angel Pons, Daisuke Nojiri, Daisuke Nojiri, build bot (Jenkins), Joel Kitching,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/33540
to look at the new patch set (#2).
Change subject: security/vboot: Remove useless 'const' ......................................................................
security/vboot: Remove useless 'const'
Change-Id: I3b5ca272abffe46c6a63251cf4905780f87a6836 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/common.c M src/security/vboot/misc.h 2 files changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/40/33540/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: security/vboot: Remove useless 'const' ......................................................................
Patch Set 3: Code-Review+1
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: security/vboot: Remove useless 'const' ......................................................................
Patch Set 3: Code-Review+2
Joel Kitching has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: security/vboot: Remove useless 'const' ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33540 )
Change subject: security/vboot: Remove useless 'const' ......................................................................
security/vboot: Remove useless 'const'
Change-Id: I3b5ca272abffe46c6a63251cf4905780f87a6836 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/33540 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org Reviewed-by: Joel Kitching kitching@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/common.c M src/security/vboot/misc.h 2 files changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Joel Kitching: Looks good to me, approved Angel Pons: Looks good to me, but someone else must approve
diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 8f8165a..bd72683 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -24,7 +24,7 @@ #include <security/vboot/symbols.h> #include <security/vboot/vboot_common.h>
-struct vboot_working_data * const vboot_get_working_data(void) +struct vboot_working_data *vboot_get_working_data(void) { struct vboot_working_data *wd = NULL;
diff --git a/src/security/vboot/misc.h b/src/security/vboot/misc.h index acb6dbb..725f5fd 100644 --- a/src/security/vboot/misc.h +++ b/src/security/vboot/misc.h @@ -53,7 +53,7 @@ /* * Source: security/vboot/common.c */ -struct vboot_working_data * const vboot_get_working_data(void); +struct vboot_working_data *vboot_get_working_data(void); void vboot_init_work_context(struct vb2_context *ctx); void vboot_finalize_work_context(struct vb2_context *ctx); struct vb2_shared_data *vboot_get_shared_data(void);
-
Aaron Durbin (Code Review) -
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Joel Kitching (Code Review)
-
Patrick Georgi (Code Review)