Change in ...coreboot[master]: mb/google/sarien/variants/sarien: Enable elan touchscreen
Chris Zhou has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31413
Change subject: mb/google/sarien/variants/sarien: Enable elan touchscreen ......................................................................
mb/google/sarien/variants/sarien: Enable elan touchscreen
BUG=b:119763054 BRANCH=master TEST=Verify touchscreen on sarien works with this change.
Signed-off-by: Chris Zhou chris_zhou@compal.corp-partner.google.com Change-Id: I790436338705fc9d68f714245e9b9bb518ddb30a --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/31413/1
diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index d3d26f9..d6563fb 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -235,6 +235,19 @@ register "hid_desc_reg_offset" = "0x0" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN900C"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "generic.probed" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" + register "generic.enable_delay_ms" = "5" + register "generic.enable_off_delay_ms" = "100" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic
EricR Lai has uploaded a new patch set (#2) to the change originally created by Chris Zhou. ( https://review.coreboot.org/c/coreboot/+/31413 )
Change subject: mb/google/sarien/variants/sarien: Enable Elan touchscreen ......................................................................
mb/google/sarien/variants/sarien: Enable Elan touchscreen
Eanble Elan touch for sarien EVT build
BUG=b:119763054 BRANCH=master TEST=Verify touchscreen on sarien works with this change.
Signed-off-by: Chris Zhou chris_zhou@compal.corp-partner.google.com Change-Id: I790436338705fc9d68f714245e9b9bb518ddb30a --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/31413/2
Simon Glass has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31413 )
Change subject: mb/google/sarien/variants/sarien: Enable Elan touchscreen ......................................................................
Patch Set 2: Code-Review+1
Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31413 )
Change subject: mb/google/sarien/variants/sarien: Enable Elan touchscreen ......................................................................
Patch Set 2: Code-Review+2
Duncan Laurie has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31413 )
Change subject: mb/google/sarien/variants/sarien: Enable Elan touchscreen ......................................................................
mb/google/sarien/variants/sarien: Enable Elan touchscreen
Eanble Elan touch for sarien EVT build
BUG=b:119763054 BRANCH=master TEST=Verify touchscreen on sarien works with this change.
Signed-off-by: Chris Zhou chris_zhou@compal.corp-partner.google.com Change-Id: I790436338705fc9d68f714245e9b9bb518ddb30a Reviewed-on: https://review.coreboot.org/c/31413 Reviewed-by: Simon Glass sjg@chromium.org Reviewed-by: Duncan Laurie dlaurie@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/sarien/variants/sarien/devicetree.cb 1 file changed, 13 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Simon Glass: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/sarien/variants/sarien/devicetree.cb b/src/mainboard/google/sarien/variants/sarien/devicetree.cb index d3d26f9..d6563fb 100644 --- a/src/mainboard/google/sarien/variants/sarien/devicetree.cb +++ b/src/mainboard/google/sarien/variants/sarien/devicetree.cb @@ -235,6 +235,19 @@ register "hid_desc_reg_offset" = "0x0" device i2c 10 on end end + chip drivers/i2c/hid + register "generic.hid" = ""ELAN900C"" + register "generic.desc" = ""ELAN Touchscreen"" + register "generic.irq" = "ACPI_IRQ_EDGE_LOW(GPP_C23_IRQ)" + register "generic.probed" = "1" + register "generic.enable_gpio" = + "ACPI_GPIO_OUTPUT_ACTIVE_HIGH(GPP_E7)" + register "generic.enable_delay_ms" = "5" + register "generic.enable_off_delay_ms" = "100" + register "generic.has_power_resource" = "1" + register "hid_desc_reg_offset" = "0x01" + device i2c 10 on end + end end # I2C #0 device pci 15.1 on chip drivers/i2c/generic
-
Chris Zhou (Code Review) -
Duncan Laurie (Code Review)
-
EricR Lai (Code Review)
-
Simon Glass (Code Review)