Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44430 )
Change subject: cse_lite: Move global reset after MRC writeback.
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/44430/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44430/2//COMMIT_MSG@7
PS2, Line 7: cse_lite: Move global reset after MRC writeback.
Please remove the dot/period at the end of the summary.
https://review.coreboot.org/c/coreboot/+/44430/2/src/soc/intel/common/block/...
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/44430/2/src/soc/intel/common/block/...
PS2, Line 660: * memory training sequence.
Please use 96 character text width.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44430
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia42d72fdec41f9792ab8f04205b20a55758a4235
Gerrit-Change-Number: 44430
Gerrit-PatchSet: 2
Gerrit-Owner: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 13 Aug 2020 15:38:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment