Attention is currently required from: Eric Lai, Nick Vaccaro, Paul Menzel, Shawn Ku, Subrata Banik.
Robert Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78253?usp=email )
Change subject: mb/google/nissa/var/quandiso: Update SD card GPIO settings
......................................................................
Patch Set 5:
(1 comment)
File src/mainboard/google/brya/variants/quandiso/gpio.c:
https://review.coreboot.org/c/coreboot/+/78253/comment/d5ae6b0f_884ce163 :
PS4, Line 93: PAD_CFG_GPO(GPP_H12, 1, DEEP),
Could you post the issue link to me? I go the that number is not your issue.
Set high GPP_H12 first is refer from neried and yaviks that same design with SD_CARD.
Sorry for the bug number mistake, right link is to b:296506936. Quandiso: Create coreboot variant
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78253?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iad6789d42b9a3f9b979fd481a88cc7d69db2dcfe
Gerrit-Change-Number: 78253
Gerrit-PatchSet: 5
Gerrit-Owner: Robert Chen
robert.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@chromium.org
Gerrit-Reviewer: Shawn Ku
shawnku@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eric Lai
ericllai@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Shawn Ku
shawnku@chromium.org
Gerrit-Comment-Date: Fri, 13 Oct 2023 02:28:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Eric Lai
ericllai@google.com
Gerrit-MessageType: comment