[S] Change in coreboot[main]: vc/edk2-stable202302: Add config guards to support FSP 2.4 - coreboot-gerrit

23 May 2024


      Attention is currently required from: Appukuttan V K, Ronak Kanabar.
Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82425?usp=email )
Change subject: vc/edk2-stable202302: Add config guards to support FSP 2.4
......................................................................
Patch Set 12:
(1 comment)
File src/vendorcode/intel/edk2/edk2-stable202302/IntelFsp2Pkg/Include/FspEas/FspApi.h:
https://review.coreboot.org/c/coreboot/+/82425/comment/d22dde2c_8d47e188?usp... :
PS12, Line 257: PLATFORM_USES_FSP2_X86_32
as per this CL, FSPM_ARCH2_UPD/FSPS_ARCH2_UPD only enable for PLATFORM_USES_FSP2_X86_64,but that is not the case. Take an example of xeon_sp where the platform still selects PLATFORM_USES_FSP2_X86_32 but FSP header declares FSPS_ARCH2_UPD/FSPM_ARCH2_UPD datatype.
worth changing the guard from PLATFORM_USES_FSP2_X86_32 to PLATFORM_USES_FSP2_4
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/82425?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Idc849de73723036323f81dfd055730f6669cd52e
Gerrit-Change-Number: 82425
Gerrit-PatchSet: 12
Gerrit-Owner: Appukuttan V K appukuttan.vk@intel.com
Gerrit-Reviewer: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Appukuttan V K appukuttan.vk@intel.com
Gerrit-Attention: Ronak Kanabar ronak.kanabar@intel.com
Gerrit-Comment-Date: Thu, 23 May 2024 10:42:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No