Attention is currently required from: Paul Menzel, Casper Chang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62703 )
Change subject: mb/google/brya/var/primus{4es}: add eMMC enable pin in ramstage
......................................................................
Patch Set 6: Code-Review+2
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62703/comment/47d5ccb2_4cbee47d
PS6, Line 9: Program the BayHub eMMC enable pin in ramstage to prevent baseboard
: override the setting leads RTD3 not able to control when enter and
: exit suspend state.
suggestion:
```
Currently the BayHub eMMC enable pin is using the default
configuration from the baseboard, which leads to RTD3 not being
able to control the GPIO when exiting and entering suspend. To fix
this, program the GPIO in the ramstage GPIO table.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/62703
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1b6f164cc326bd368addb1e143ad2cbd449bb08d
Gerrit-Change-Number: 62703
Gerrit-PatchSet: 6
Gerrit-Owner: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Ariel Fang
ariel_fang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu
malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Raihow Shi
raihow_shi@wistron.corp-partner.google.com
Gerrit-CC: Terry Chen
terry_chen@wistron.corp-partner.google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-Comment-Date: Fri, 11 Mar 2022 04:57:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment