Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: 3rdparty/vboot: update to latest master ......................................................................
3rdparty/vboot: update to latest master
This includes several fixes to issues found by Coverity Scan.
Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/35315/1
diff --git a/3rdparty/vboot b/3rdparty/vboot index e6700f4..5cb2e84 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e6700f4c70fe72850ae4f3f5df19c9281ebcefc8 +Subproject commit 5cb2e84a191583f0e4d01ee6077404f85531f6c7
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2:
This change is ready for review.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2: Code-Review+1
Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2: Code-Review+1
Selma Bensaid has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2:
We are facing a build error with this version of vboot gcc: error: unrecognized command line option '-Wimplicit-fallthrough' Is this version of vboot requires a newer GCC version?
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 2:
Patch Set 2:
We are facing a build error with this version of vboot gcc: error: unrecognized command line option '-Wimplicit-fallthrough' Is this version of vboot requires a newer GCC version?
What compiler are you using? We generally expect developers to use our coreboot-sdk toolchain (from util/crossgcc) for reproducible results.
Hello Selma Bensaid, Paul Menzel, build bot (Jenkins), Krzysztof M Sywula,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/35315
to look at the new patch set (#3).
Change subject: Update vboot submodule to upstream master ......................................................................
Update vboot submodule to upstream master
Updating from commit id e6700f4c: 2019-08-13 04:36:52 +0000 - (vboot: update vboot2 functions to use new vb2_error_t)
to commit id b2c8984d: 2019-10-01 06:01:59 +0000 - (vboot: fix compile error with MOCK_TPM)
This brings in 71 new commits.
Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/15/35315/3
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Patch Set 3: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/35315 )
Change subject: Update vboot submodule to upstream master ......................................................................
Update vboot submodule to upstream master
Updating from commit id e6700f4c: 2019-08-13 04:36:52 +0000 - (vboot: update vboot2 functions to use new vb2_error_t)
to commit id b2c8984d: 2019-10-01 06:01:59 +0000 - (vboot: fix compile error with MOCK_TPM)
This brings in 71 new commits.
Change-Id: Id7cefa3ad5b30c955d18e469494fec32f6f58a48 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/35315 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org --- M 3rdparty/vboot 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Stefan Reinauer: Looks good to me, approved
diff --git a/3rdparty/vboot b/3rdparty/vboot index e6700f4..b2c8984 160000 --- a/3rdparty/vboot +++ b/3rdparty/vboot @@ -1 +1 @@ -Subproject commit e6700f4c70fe72850ae4f3f5df19c9281ebcefc8 +Subproject commit b2c8984d37e378b2faad170d4ec9b378c0c2b145
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)
-
Selma Bensaid (Code Review)
-
Stefan Reinauer (Code Review)