Change in coreboot[master]: kconfig: remove non-existent source

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Jack Rosenthal (Code Review)

16 Dec 2020 16 Dec '20

11:36 p.m.

Hello Martin Roth, Patrick Georgi,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/48676

to review the following change.

Change subject: kconfig: remove non-existent source ......................................................................

kconfig: remove non-existent source

src/northbridge/amd/pi/00660F01/Kconfig does not exist. Remove the source statement.

Signed-off-by: Jack Rosenthal jrosenth@chromium.org Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 --- M src/northbridge/amd/pi/Kconfig 1 file changed, 0 insertions(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/48676/1

diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig index 833afae..15e685b 100644 --- a/src/northbridge/amd/pi/Kconfig +++ b/src/northbridge/amd/pi/Kconfig @@ -29,7 +29,6 @@

source "src/northbridge/amd/pi/00630F01/Kconfig" source "src/northbridge/amd/pi/00730F01/Kconfig" -source "src/northbridge/amd/pi/00660F01/Kconfig"

config HW_MEM_HOLE_SIZEK hex

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Nico Huber (Code Review)

17 Dec 17 Dec

10:47 p.m.

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48676 )

Change subject: kconfig: remove non-existent source ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Gerrit-Change-Number: 48676 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 17 Dec 2020 20:47:58 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Jack Rosenthal (Code Review)

10:49 p.m.

Jack Rosenthal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48676 )

Change subject: kconfig: remove non-existent source ......................................................................

Patch Set 1:

Thanks for the stamp 😊

I don't have permission to submit if someone can do it for me.

-- To view, visit https://review.coreboot.org/c/coreboot/+/48676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Gerrit-Change-Number: 48676 Gerrit-PatchSet: 1 Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 17 Dec 2020 20:49:27 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Jack Rosenthal (Code Review)

18 Dec 18 Dec

12:56 a.m.

Hello build bot (Jenkins), Nico Huber, Martin Roth, Patrick Georgi,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/48676

to look at the new patch set (#2).

Change subject: kconfig: remove non-existent source ......................................................................

kconfig: remove non-existent source

src/northbridge/amd/pi/00660F01/Kconfig does not exist. Remove the source statement.

Also, no kconfig files under src/soc/intel/common/basecode/. Clean that up.

Signed-off-by: Jack Rosenthal jrosenth@chromium.org Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 --- M src/northbridge/amd/pi/Kconfig M src/soc/intel/common/basecode/Kconfig 2 files changed, 0 insertions(+), 8 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/48676/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Gerrit-Change-Number: 48676 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Martin Roth (Code Review)

24 Dec 24 Dec

10:17 p.m.

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48676 )

Change subject: kconfig: remove non-existent source ......................................................................

Patch Set 2: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/48676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Gerrit-Change-Number: 48676 Gerrit-PatchSet: 2 Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Dec 2020 20:17:06 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Hung-Te Lin (Code Review)

28 Dec 28 Dec

3:37 p.m.

Hung-Te Lin has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48676 )

Change subject: kconfig: remove non-existent source ......................................................................

kconfig: remove non-existent source

src/northbridge/amd/pi/00660F01/Kconfig does not exist. Remove the source statement.

Also, no kconfig files under src/soc/intel/common/basecode/. Clean that up.

Signed-off-by: Jack Rosenthal jrosenth@chromium.org Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Reviewed-on: https://review.coreboot.org/c/coreboot/+/48676 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Martin Roth martinroth@google.com --- M src/northbridge/amd/pi/Kconfig M src/soc/intel/common/basecode/Kconfig 2 files changed, 0 insertions(+), 8 deletions(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved

diff --git a/src/northbridge/amd/pi/Kconfig b/src/northbridge/amd/pi/Kconfig index 833afae..15e685b 100644 --- a/src/northbridge/amd/pi/Kconfig +++ b/src/northbridge/amd/pi/Kconfig @@ -29,7 +29,6 @@

source "src/northbridge/amd/pi/00630F01/Kconfig" source "src/northbridge/amd/pi/00730F01/Kconfig" -source "src/northbridge/amd/pi/00660F01/Kconfig"

config HW_MEM_HOLE_SIZEK hex diff --git a/src/soc/intel/common/basecode/Kconfig b/src/soc/intel/common/basecode/Kconfig index 1c93244..9e0f788 100644 --- a/src/soc/intel/common/basecode/Kconfig +++ b/src/soc/intel/common/basecode/Kconfig @@ -2,10 +2,3 @@ bool help Common coreboot stages and non-IP block for Intel platform - -if SOC_INTEL_COMMON_BASECODE - -source "src/soc/intel/common/basecode/*/Kconfig" -source "src/soc/intel/common/basecode/*/*/Kconfig" - -endif

-- To view, visit https://review.coreboot.org/c/coreboot/+/48676 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I10917b76ff6c2a9d5a97d5c7dfa9e8925cd8c8a4 Gerrit-Change-Number: 48676 Gerrit-PatchSet: 3 Gerrit-Owner: Jack Rosenthal jrosenth@chromium.org Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1491

days inactive

1503

days old

coreboot-gerrit@coreboot.org

5 comments

4 participants

tags (0)

participants (4)

Hung-Te Lin (Code Review)
Jack Rosenthal (Code Review)
Martin Roth (Code Review)
Nico Huber (Code Review)