Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/20471
to look at the new patch set (#2).
Change subject: siemens/nc_fpga: Modify macro FPGA_SET_PARAM to avoid hwilib errors ......................................................................
siemens/nc_fpga: Modify macro FPGA_SET_PARAM to avoid hwilib errors
The macro FPGA_SET_PARAM was introduced to make the setting of different FPGA registers with the appropriate values from hwinfo more transparent. The hwilib takes care about the size of the provided buffer where the requested value should be stored in. The fields in hwinfo have not always the same size as the matching registers in the FPGA. So to avoid errors resulting in a too small buffer when calling hwilib_get_field() the buffer is now fixed to 32 bit and will be casted to the destination type when the value is written into the FPGA register.
Changing the field size in hwilib would be the wrong way as the defined lengths are specified this way to be expandable in the future.
In addition the number of maximum supported temperature sensors in increased to 8 as the FPGA now supports more.
Change-Id: I0c697106783158420708a973c3cff2be90fa4fce Signed-off-by: Werner Zeh werner.zeh@siemens.com --- M src/drivers/siemens/nc_fpga/nc_fpga.c M src/drivers/siemens/nc_fpga/nc_fpga.h 2 files changed, 5 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/71/20471/2