Attention is currently required from: Dinesh Gehlot, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Rui Zhou, Subrata Banik.
Paul Menzel has posted comments on this change by Rui Zhou. ( https://review.coreboot.org/c/coreboot/+/85015?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/nissa/var/rull: Add Elan touchscreen ......................................................................
Patch Set 6: Code-Review+1
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85015/comment/cb4f637d_f8697203?usp... : PS6, Line 7: Add Elan touchscreen … to devicetree
https://review.coreboot.org/c/coreboot/+/85015/comment/66d1e607_d78eaee0?usp... : PS6, Line 7: Elan ELAN
https://review.coreboot.org/c/coreboot/+/85015/comment/f551716b_d373d395?usp... : PS6, Line 9: Add Elan touchscreen override devicetree for rull based on the latest schematic NB7559_MB_SCH_V1_2024_1010.pdf. Please wrap the line after 72 characters.
https://review.coreboot.org/c/coreboot/+/85015/comment/5a7df8bd_a2499049?usp... : PS6, Line 13: touchpanel function is normal What commands did you run? xev? Any log line, one could check?
File src/mainboard/google/brya/variants/rull/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/85015/comment/e3e1d1a3_a33e79ce?usp... : PS6, Line 232: register "generic.stop_delay_ms" = "150" Is 150 ms mentioned in the schematics or some datasheet?
-
Paul Menzel (Code Review)