Attention is currently required from: Nico Huber, Krishna Prabhakaran, Furquan Shaikh, Maulik V Vaghela, Selma Bensaid, Meera Ravindranath, Patrick Rudolph.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52758 )
Change subject: drivers/intel/gma: Support IGD Opregion 2.1
......................................................................
Patch Set 13:
(1 comment)
File src/drivers/intel/gma/Kconfig:
https://review.coreboot.org/c/coreboot/+/52758/comment/d850b686_b7ac7b01
PS13, Line 105: INTEL_GMA_OPREGION_2_0
I would recommend to make 2. […]
What determines this support? Isn't this just something that the kernel driver needs to support?
yes, you are right. If we drop support for 2_0, then it has to be communicated and what is the expectation also needs to call out. I guess we have some data on that too. @meera, wasn't there a display issue when we are passing 2_0 and driver expects 2_1?
Or are there other factors? If it is just the kernel driver dependency, would it make sense to announce this deprecation in coreboot and drop support for 2.0 in next 6-12 months?
Yes, better to take that call into sometime from now as you said 6-12month and we notify others. Thoughts ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52758
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I95a9f3df185002a4e38faa910f867ace0b97ac2b
Gerrit-Change-Number: 52758
Gerrit-PatchSet: 13
Gerrit-Owner: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Krishna Prabhakaran
krishna.prabhakaran@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Selma Bensaid
selma.bensaid@intel.com
Gerrit-Attention: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Thu, 08 Jul 2021 06:53:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Meera Ravindranath
meera.ravindranath@intel.com
Gerrit-MessageType: comment