Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61802 )
Change subject: nb/intel/i945/rcven.c: Use 'enum cb_err' instead of 'int' ......................................................................
Patch Set 5:
(2 comments)
File src/northbridge/intel/i945/rcven.c:
https://review.coreboot.org/c/coreboot/+/61802/comment/eea52796_62de0250 PS5, Line 196: printk(BIOS_DEBUG, "Could not find low strobe\n"); : return 0 return -1;?
https://review.coreboot.org/c/coreboot/+/61802/comment/240848e5_80739d5a PS5, Line 106: mchbar_write8(C0WL0REOST + channel_offset, *fine) C{0,1}WL1REOST, C{0,1}WL2REOST and C{0,1}WL3REOST are missing ?