Sridhar Siricilla has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/39023 )
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
soc/intel/common: Log CSE's RO and RW versions
Since CSE FW Custom SKU has RO and RW partitions and each can have different versions, so skip sending GET_FW_VERSION command which fetches version of CSE RW. Instead call cse_print_boot_partition_info() which logs CSE's RO(BP1) and RW(BP2) versions. The cse_print_boot_partition_info() function sends GET_BOOT_PARTITION_INFO HECI command to CSE.
TEST=Verified on hatch
Change-Id: Iffd2986adaecf24590e635deaa9794ad85a24115 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/39023/1
diff --git a/src/soc/intel/common/block/cse/cse.c b/src/soc/intel/common/block/cse/cse.c index bf2ae3f..e0f42d4 100644 --- a/src/soc/intel/common/block/cse/cse.c +++ b/src/soc/intel/common/block/cse/cse.c @@ -834,8 +834,10 @@ * Ignore if ME Firmware SKU type is custom since * print_boot_partition_info() logs RO(BP1) and RW(BP2) versions. */ - if (cse_is_hfs3_fw_sku_custom()) + if (cse_is_hfs3_fw_sku_custom()) { + cse_print_boot_partition_info(); return; + }
/* * Prerequisites:
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/39023
to look at the new patch set (#5).
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
soc/intel/common: Log CSE's RO and RW versions
Since CSE FW Custom SKU has RO and RW partitions and each can have different versions, so skip sending GET_FW_VERSION command which fetches version of CSE RW. Instead call cse_print_boot_partition_info() which logs CSE's RO(BP1) and RW(BP2) versions. The cse_print_boot_partition_info() function sends GET_BOOT_PARTITION_INFO HECI command to CSE.
TEST=Verified on hatch
Change-Id: Iffd2986adaecf24590e635deaa9794ad85a24115 Signed-off-by: Sridhar Siricilla sridhar.siricilla@intel.com --- M src/soc/intel/common/block/cse/cse.c 1 file changed, 3 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/39023/5
Sridhar Siricilla has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/39023 )
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
Abandoned
ME RO and RW will be logged as part of enabling CSE Firmware SKU Custom . Hence the patch is not required.
Sridhar Siricilla has removed Patrick Rudolph from this change. ( https://review.coreboot.org/c/coreboot/+/39023 )
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
Removed reviewer Patrick Rudolph.
Sridhar Siricilla has removed Paul Menzel from this change. ( https://review.coreboot.org/c/coreboot/+/39023 )
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
Removed reviewer Paul Menzel.
Sridhar Siricilla has removed build bot (Jenkins) from this change. ( https://review.coreboot.org/c/coreboot/+/39023 )
Change subject: soc/intel/common: Log CSE's RO and RW versions ......................................................................
Removed reviewer build bot (Jenkins).