[M] Change in coreboot[main]: util/amdfwtool: Add binary parsing - coreboot-gerrit

2 Dec 2024


      Attention is currently required from: Ana Carolina Cabral, Anand Vaikar, Bao Zheng, Marshall Dawson, Maximilian Brune, Paul Menzel.
Felix Held has posted comments on this change by Maximilian Brune. ( https://review.coreboot.org/c/coreboot/+/84373?usp=email )
Change subject: util/amdfwtool: Add binary parsing
......................................................................
Patch Set 8:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/84373/comment/0b8ab5f0_081021b8?usp... :
PS8, Line 324: 	{ .type = AMD_BIOS_APOB_NV, .level = BDT_BOTH },
...
Are you sure this is required?  Or maybe it became a requirement on glinda?  IIRC we've traditionall […]
iirc glinda doesn't use/have a level 1 bios directory table
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/84373?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I78d7a9dba71de557e0a9a885d8561eea1f4191ef
Gerrit-Change-Number: 84373
Gerrit-PatchSet: 8
Gerrit-Owner: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Reviewer: Anand Vaikar a.vaikar2021@gmail.com
Gerrit-Reviewer: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Ana Carolina Cabral
Gerrit-CC: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Maximilian Brune maximilian.brune@9elements.com
Gerrit-Attention: Anand Vaikar a.vaikar2021@gmail.com
Gerrit-Attention: Ana Carolina Cabral
Gerrit-Comment-Date: Mon, 02 Dec 2024 19:31:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Marshall Dawson marshalldawson3rd@gmail.com