Attention is currently required from: Andrey Petrov.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63225 )
Change subject: soc/intel/apl: Drop cbfs bootblock
......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/apollolake/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/63225/comment/11ad1997_97a83f73
PS5, Line 149: $(obj)/fit_placeholder:
: dd if=/dev/zero of=$@ bs=64 count=1 &>/dev/null
:
: cbfs-files-y += fit_pointer
: fit_pointer-file := $(obj)/fit_placeholder
: fit_pointer-position := -64
: fit_pointer-type := "cbfs header"
this seems unnecessary
nvm, it is needed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63225
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8e70e080765dd7306074a8cf71c8795b8fbbb8a2
Gerrit-Change-Number: 63225
Gerrit-PatchSet: 5
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Comment-Date: Tue, 05 Apr 2022 10:36:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment