Attention is currently required from: Arthur Heymans, Eric Lai, Kapil Porwal, Paul Menzel, Sumeet R Pawnikar.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78386?usp=email )
Change subject: drivers/intel/dptf: Add DCFG support
......................................................................
Patch Set 6:
(1 comment)
File src/drivers/intel/dptf/chip.h:
https://review.coreboot.org/c/coreboot/+/78386/comment/32cb5afa_23b0b830 :
PS5, Line 77: uint32_t
DCFG is 32 bit register.
that I can see from the type declaration. but wanted to know if the values are like bit maps or there are any ranges for say? i mean if zero value is value or 0xFFFFFFFF is also valid ?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78386?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I507c4d6eee565d39b2f42950d888d110ab94de64
Gerrit-Change-Number: 78386
Gerrit-PatchSet: 6
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Wed, 20 Mar 2024 06:24:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-MessageType: comment