Change in coreboot[master]: util/mb/google: Update dalboz/trembyle template

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Rob Barnes (Code Review)

31 Aug 2020 31 Aug '20

5:04 p.m.

Rob Barnes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

Fix relative path to spd folder.

BUG=b:167175547 TEST=None

Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Signed-off-by: Rob Barnes robbarnes@google.com --- M util/mainboard/google/dalboz/template/Makefile.inc M util/mainboard/google/trembyle/template/Makefile.inc 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44947/1

diff --git a/util/mainboard/google/dalboz/template/Makefile.inc b/util/mainboard/google/dalboz/template/Makefile.inc index 9dc5159..295acd2 100644 --- a/util/mainboard/google/dalboz/template/Makefile.inc +++ b/util/mainboard/google/dalboz/template/Makefile.inc @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-or-later

-subdirs-y += ../baseboard/spd +subdirs-y += ./spd diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.inc index 9dc5159..295acd2 100644 --- a/util/mainboard/google/trembyle/template/Makefile.inc +++ b/util/mainboard/google/trembyle/template/Makefile.inc @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-or-later

-subdirs-y += ../baseboard/spd +subdirs-y += ./spd

Attachments:

attachment.htm (text/html — 3.0 KB)

Show replies by date

Furquan Shaikh (Code Review)

31 Aug 31 Aug

5:10 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 1:

This looks okay to me, but one thing to consider here is that spd/ directory will not be present under the variant directory when a new variant is added using this script. Do we just want to leave this spd/ addition to Makefile here and in follow-up CLs, memory parts should get added? Would that be the workflow?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 20:10:12 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

5:26 p.m.

Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 1:

...

Patch Set 1:

This looks okay to me, but one thing to consider here is that spd/ directory will not be present under the variant directory when a new variant is added using this script. Do we just want to leave this spd/ addition to Makefile here and in follow-up CLs, memory parts should get added? Would that be the workflow?

How about we add an empty spd/mem_parts_used.txt and a spd/Makefile.inc with an empty SPD_SOURCES. That would create the structure and hint that these files need to be configured for the variant.

With a one line change to gen_part_id.go we can enable comments in mem_parts_used.txt. Then we can add instructions at the top of the empty mem_parts_used.txt.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 20:26:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Furquan Shaikh (Code Review)

5:27 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 1:

...

Patch Set 1:

...
Patch Set 1:

This looks okay to me, but one thing to consider here is that spd/ directory will not be present under the variant directory when a new variant is added using this script. Do we just want to leave this spd/ addition to Makefile here and in follow-up CLs, memory parts should get added? Would that be the workflow?

How about we add an empty spd/mem_parts_used.txt and a spd/Makefile.inc with an empty SPD_SOURCES. That would create the structure and hint that these files need to be configured for the variant.

With a one line change to gen_part_id.go we can enable comments in mem_parts_used.txt. Then we can add instructions at the top of the empty mem_parts_used.txt.

SGTM.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 20:27:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

Aaron Durbin (Code Review)

5:35 p.m.

Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 1 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 20:35:01 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Rob Barnes (Code Review)

6:40 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Fagerburg, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44947

to look at the new patch set (#2).

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

Fix relative path to spd folder. Add spd folder with empty files.

BUG=None TEST=None

Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Signed-off-by: Rob Barnes robbarnes@google.com --- M util/mainboard/google/dalboz/template/Makefile.inc A util/mainboard/google/dalboz/template/spd/Makefile.inc A util/mainboard/google/dalboz/template/spd/dram_id.generated.txt A util/mainboard/google/dalboz/template/spd/mem_parts_used.txt M util/mainboard/google/trembyle/template/Makefile.inc A util/mainboard/google/trembyle/template/spd/Makefile.inc A util/mainboard/google/trembyle/template/spd/dram_id.generated.txt A util/mainboard/google/trembyle/template/spd/mem_parts_used.txt 8 files changed, 30 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44947/2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

build bot (Jenkins) (Code Review)

6:42 p.m.

build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 2:

(2 comments)

https://review.coreboot.org/c/coreboot/+/44947/2/util/mainboard/google/dalbo... File util/mainboard/google/dalboz/template/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/44947/2/util/mainboard/google/dalbo... PS2, Line 1: # This is a CSV file containg a list of memory parts used by this variant. 'containg' may be misspelled - perhaps 'containing'?

https://review.coreboot.org/c/coreboot/+/44947/2/util/mainboard/google/tremb... File util/mainboard/google/trembyle/template/spd/mem_parts_used.txt:

https://review.coreboot.org/c/coreboot/+/44947/2/util/mainboard/google/tremb... PS2, Line 1: # This is a CSV file containg a list of memory parts used by this variant. 'containg' may be misspelled - perhaps 'containing'?

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 2 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 21:42:10 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Rob Barnes (Code Review)

6:51 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Fagerburg, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44947

to look at the new patch set (#3).

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

Fix relative path to spd folder. Add spd folder with empty files.

BUG=None TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44947/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 3 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Rob Barnes (Code Review)

7:30 p.m.

Hello build bot (Jenkins), Furquan Shaikh, Patrick Georgi, Martin Roth, Paul Fagerburg, Aaron Durbin,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/44947

to look at the new patch set (#4).

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

Fix relative path to spd folder. Add spd folder with empty files.

BUG=None TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44947/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Furquan Shaikh (Code Review)

7:43 p.m.

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 22:43:37 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Fagerburg (Code Review)

8:44 p.m.

Paul Fagerburg has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 31 Aug 2020 23:44:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Paul Menzel (Code Review)

1 Sep 1 Sep

10:06 a.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 4:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44947/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44947/4//COMMIT_MSG@9 PS4, Line 9: Fix relative path to spd folder. : Add spd folder with empty files. Please format it as a list/enumeration.

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 4 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Tue, 01 Sep 2020 13:06:25 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment

Patrick Georgi (Code Review)

9 Sep 9 Sep

7:46 a.m.

Patrick Georgi has uploaded a new patch set (#5) to the change originally created by Rob Barnes. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

- Fix relative path to spd folder. - Add spd folder with empty files.

BUG=None TEST=None

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/47/44947/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 5 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Patrick Georgi (Code Review)

7:46 a.m.

Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

Patch Set 5:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44947/4//COMMIT_MSG Commit Message:

https://review.coreboot.org/c/coreboot/+/44947/4//COMMIT_MSG@9 PS4, Line 9: Fix relative path to spd folder. : Add spd folder with empty files.

...

Please format it as a list/enumeration.

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 5 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Comment-Date: Wed, 09 Sep 2020 10:46:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: comment

Patrick Georgi (Code Review)

7:46 a.m.

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44947 )

Change subject: util/mb/google: Update dalboz/trembyle template ......................................................................

util/mb/google: Update dalboz/trembyle template

- Fix relative path to spd folder. - Add spd folder with empty files.

BUG=None TEST=None

Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Signed-off-by: Rob Barnes robbarnes@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44947 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Paul Fagerburg pfagerburg@chromium.org --- M util/mainboard/google/dalboz/template/Makefile.inc A util/mainboard/google/dalboz/template/spd/Makefile.inc A util/mainboard/google/dalboz/template/spd/dram_id.generated.txt A util/mainboard/google/dalboz/template/spd/mem_parts_used.txt M util/mainboard/google/trembyle/template/Makefile.inc A util/mainboard/google/trembyle/template/spd/Makefile.inc A util/mainboard/google/trembyle/template/spd/dram_id.generated.txt A util/mainboard/google/trembyle/template/spd/mem_parts_used.txt 8 files changed, 30 insertions(+), 2 deletions(-)

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Paul Fagerburg: Looks good to me, approved

-subdirs-y += ../baseboard/spd +subdirs-y += ./spd diff --git a/util/mainboard/google/dalboz/template/spd/Makefile.inc b/util/mainboard/google/dalboz/template/spd/Makefile.inc new file mode 100644 index 0000000..feabe7f --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/Makefile.inc @@ -0,0 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = diff --git a/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt b/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt b/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/dalboz/template/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional) diff --git a/util/mainboard/google/trembyle/template/Makefile.inc b/util/mainboard/google/trembyle/template/Makefile.inc index 9dc5159..295acd2 100644 --- a/util/mainboard/google/trembyle/template/Makefile.inc +++ b/util/mainboard/google/trembyle/template/Makefile.inc @@ -1,3 +1,3 @@ # SPDX-License-Identifier: GPL-2.0-or-later

-subdirs-y += ../baseboard/spd +subdirs-y += ./spd diff --git a/util/mainboard/google/trembyle/template/spd/Makefile.inc b/util/mainboard/google/trembyle/template/spd/Makefile.inc new file mode 100644 index 0000000..feabe7f --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/Makefile.inc @@ -0,0 +1,4 @@ +## SPDX-License-Identifier: GPL-2.0-or-later +## This is an auto-generated file. Do not edit!! + +SPD_SOURCES = diff --git a/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt b/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt new file mode 100644 index 0000000..fa24790 --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/dram_id.generated.txt @@ -0,0 +1 @@ +DRAM Part Name ID to assign diff --git a/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt b/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt new file mode 100644 index 0000000..106a705 --- /dev/null +++ b/util/mainboard/google/trembyle/template/spd/mem_parts_used.txt @@ -0,0 +1,9 @@ +# This is a CSV file containing a list of memory parts used by this variant. +# One part per line with an optional fixed ID in column 2. +# Only include a fixed ID if it is required for legacy reasons! +# Each part must also be listed in util/spd_tools/ddr4/global_ddr4_mem_parts.json.txt. +# Generate an updated Makefile.inc and dram_id.generated.txt by running the +# gen_part_id tool from util/spd_tools/ddr4. +# See util/spd_tools/ddr4/README.md for more details and instructions. + +# Part Name, Fixed ID (optional)

-- To view, visit https://review.coreboot.org/c/coreboot/+/44947 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: Iae88ff9c8255f60544312f0eeadf1ce617437baf Gerrit-Change-Number: 44947 Gerrit-PatchSet: 6 Gerrit-Owner: Rob Barnes robbarnes@google.com Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org Gerrit-Reviewer: Furquan Shaikh furquan@google.com Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Fagerburg pfagerburg@chromium.org Gerrit-Reviewer: Paul Fagerburg pfagerburg@google.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: merged

1685

days inactive

1694

days old

coreboot-gerrit@coreboot.org

14 comments

7 participants

tags (0)

participants (7)

Aaron Durbin (Code Review)
build bot (Jenkins) (Code Review)
Furquan Shaikh (Code Review)
Patrick Georgi (Code Review)
Paul Fagerburg (Code Review)
Paul Menzel (Code Review)
Rob Barnes (Code Review)