Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Paul Menzel.
Sugnan Prabhu S has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56750 )
Change subject: vc/google/chromeos: Add support for new SAR tables revisions
......................................................................
Patch Set 12:
(1 comment)
File src/vendorcode/google/chromeos/sar_v2.c:
PS12:
I am not convinced this has to be broken out into a separate file. […]
Tim,
In legacy implementation WGDS uses CONFIG_GEO_SAR_ENABLE to decide whether the block is present or not.
In current implementation WGDS version will always be present which will be set to invalid incase the block is not present.
As SAR revision is not present in the legacy implementation, we need to add extra byte incase USE_SAR
https://review.coreboot.org/c/coreboot/+/56750/12/src/vendorcode/google/chro...
This will lead to too many if(CONFIG(USE_SAR)) checks and affect the code readability, hence I tried to separate it in different file.
I will try to update the code as suggested and have it in single file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56750
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I08c3f321938eba04e8bcff4d87cb215422715bb2
Gerrit-Change-Number: 56750
Gerrit-PatchSet: 12
Gerrit-Owner: Sugnan Prabhu S
sugnan.prabhu.s@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Dtrain Hsu
dtrain_hsu@compal.corp-partner.google.com
Gerrit-CC: Jamie Chen
jamie.chen@intel.com
Gerrit-CC: Janiex Tu
janiex.tu@intel.corp-partner.google.com
Gerrit-CC: Matt Chen
matt.chen@intel.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 17 Aug 2021 04:46:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment