Attention is currently required from: Arthur Heymans, Furquan Shaikh, Subrata Banik, Johnny Lin, Ed Sharma, Paul Menzel, Tim Wawrzynczak, Julian Schroeder, Nathaniel L Desimone, Felix Held, Isaac W Oram.
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/66819 )
Change subject: commonlib/fsp_relocate: add PE32 section support
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
Possible for you to share the snippet of the FSP .dsc file where you have PE image being added. […]
Hi Subrata, Eddie and I only have access to the binary, but not the source code (FSP .dsc file). Nate is a reviewer in this thread; if he does not follow this, we may want to discuss with him via email as necessary.
coreboot does not have support for PE32, I wonder why it has been working with client FSP which has FSP-S modules as PE32. Could you try this patch out, and dig a bit more?
PS4:
Thanks Subrata for the review.
Nate/Isaac, could you check out this conversation?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/66819
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I01e2c123d74f735a647b994aa66419c9796f193e
Gerrit-Change-Number: 66819
Gerrit-PatchSet: 4
Gerrit-Owner: Ed Sharma
aeddiesharma@fb.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: Ed Sharma
aeddiesharma@fb.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Attention: Julian Schroeder
julianmarcusschroeder@gmail.com
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Isaac W Oram
isaac.w.oram@intel.com
Gerrit-Comment-Date: Mon, 12 Sep 2022 05:40:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment