[S] Change in coreboot[main]: ec/google/chromeec: Add read_battery_status to get dynamic battery flags
Attention is currently required from: Boris Mittelberg, Brandon Breitenstein, Hannah Williams, Jamie Ryu, Kapil Porwal, Subrata Banik, Sukumar Ghorai.
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78321?usp=email )
Change subject: ec/google/chromeec: Add read_battery_status to get dynamic battery flags ......................................................................
Patch Set 4:
(1 comment)
File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/78321/comment/fceaab3e_6a068764 : PS4, Line 1543: if (ec_cmd_battery_get_dynamic(PLAT_EC, &dynamic_p, &dynamic_r) != 0)
ya, if the host command fails, propagate failure to caller, […]
the EC also has power limits for when it is feasible to power on the AP. we need to check if they are different for "locked" systems (e.g. PVT, production units) vs. "unlocked" units (pre-PVT and CCD open'd units, etc).
in any case... we could, for example, require a 30 W charger (no battery case) to get here, then the AP applies the low power profile and boots to the kernel (hopefully).
there are other parameters for booting on battery, battery+ac, minimum battery charge, etc... need to stare at the EC code to figure out exactly which permutations are already supported.
if we decide to get fancy about this, we could even pop up a firmware screen stating that we're booting in degraded mode.
-
Caveh Jalali (Code Review)