Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Martin L Roth.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77179?usp=email )
Change subject: commonlib: Remove unused CBMEM ID
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS1:
I don't think we want to get rid of this immediately just because it's been refactored out. There are still devices in use that will have this CBMEM ID. I'd suggest waiting a while to remove it. Or just leave it in permanently - It's not hurting anything.
can u please highlight the devices that you sense is using this CBMEM ID? we have added those for a new feature and eventually the new feature is now branded as VSD hence, just using a better macro instead this one.
@Martin, any further thoughts ? do you have any objection with this CL ?
marking resolved based on last ping
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77179?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I83f53b7f64bdef62a8ee2061d5a9c9e22bc4b8a4
Gerrit-Change-Number: 77179
Gerrit-PatchSet: 4
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Thu, 17 Aug 2023 22:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin L Roth
gaumless@gmail.com
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Gerrit-MessageType: comment