Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48582 )
Change subject: device + util/sconfig: introduce new device `gpio`
......................................................................
Patch Set 15:
(3 comments)
https://review.coreboot.org/c/coreboot/+/48582/14//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/48582/14//COMMIT_MSG@12
PS14, Line 12: ,
I guess the comma is spurious in English.
ack
https://review.coreboot.org/c/coreboot/+/48582/14//COMMIT_MSG@17
PS14, Line 17: them to the generic device operations struct, which then gets assigned to
Line is too long (and `to` fits in the next one).
Done
https://review.coreboot.org/c/coreboot/+/48582/14//COMMIT_MSG@30
PS14, Line 30: a
*an*
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48582
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic4572ad8b37bd1afd2fb213b2c67fb8aec536786
Gerrit-Change-Number: 48582
Gerrit-PatchSet: 15
Gerrit-Owner: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 28 Dec 2020 16:47:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment