Hello Felix Singer, build bot (Jenkins), Nico Huber, Furquan Shaikh, Paul Menzel, Tim Wawrzynczak, Subrata Banik, Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47195
to look at the new patch set (#8).
Change subject: soc/intel/cnl: replace the remaints of HeciEnabled by device state in dt ......................................................................
soc/intel/cnl: replace the remaints of HeciEnabled by device state in dt
The option `HeciEnabled` was partly replaced by use of the device on/off state in the devicetree in commit 3de90d1. The option has been removed from the corresponding boards, so `HeciEnabled` is always 0 and ME gets always gets disabled during soc finalize, when `HECI_DISABLE_USING_SMM` is set.
Replace the option in the finalize function by the same dt state check that sets the FSP option and drop the remaints of `HeciEnabled`.
Devicetrees still having `HeciEnabled` have been adapted to keep the current behaviour.
Change-Id: Ib4cca9099b9aa3434552a41fbafca7cf6a0dd0eb Signed-off-by: Michael Niewöhner foss@mniewoehner.de --- M src/mainboard/google/hatch/variants/ambassador/overridetree.cb M src/mainboard/google/hatch/variants/genesis/overridetree.cb M src/mainboard/prodrive/hermes/devicetree.cb M src/mainboard/siemens/chili/variants/base/devicetree.cb M src/mainboard/siemens/chili/variants/chili/devicetree.cb M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/smihandler.c 7 files changed, 9 insertions(+), 23 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/95/47195/8