Hello Wisley Chen,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/47855
to review the following change.
Change subject: mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC
Add H5ANAG6NCJR-XNC.
BUG=b:165461530 BRANCH=volteer TEST=emerge-volteer coreboot
Change-Id: I827158ce0abe764f1e3b5de46abf50dc148a6ff0 --- M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc M src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/47855/1
diff --git a/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc b/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc index 2685fcd..0a9e3f9 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc @@ -5,3 +5,4 @@ SPD_SOURCES += ddr4-spd-2.hex # ID = 0(0b0000) Parts = H5ANAG6NCMR-XNC SPD_SOURCES += ddr4-spd-7.hex # ID = 1(0b0001) Parts = MT40A1G16KD-062E:E, K4AAG165WA-BCWE SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = H5AN8G6NDJR-XNC, MT40A512M16TB-062E:J, K4A8G165WC-BCWE +SPD_SOURCES += ddr4-spd-9.hex # ID = 3(0b0011) Parts = H5ANAG6NCJR-XNC diff --git a/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt index c892d9b..e85149b 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt @@ -5,3 +5,4 @@ H5AN8G6NDJR-XNC 2 (0010) MT40A512M16TB-062E:J 2 (0010) K4A8G165WC-BCWE 2 (0010) +H5ANAG6NCJR-XNC 3 (0011) diff --git a/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt index 939d85f..b110e92 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt +++ b/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt @@ -4,3 +4,4 @@ H5AN8G6NDJR-XNC MT40A512M16TB-062E:J K4A8G165WC-BCWE +H5ANAG6NCJR-XNC
Hello build bot (Jenkins), Patrick Georgi, Martin Roth, Wisley Chen,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47855
to look at the new patch set (#2).
Change subject: mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC
Add H5ANAG6NCJR-XNC.
BUG=b:165461530 BRANCH=volteer TEST=emerge-volteer coreboot
Change-Id: I827158ce0abe764f1e3b5de46abf50dc148a6ff0 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com --- M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc M src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/55/47855/2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47855 )
Change subject: mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC ......................................................................
Patch Set 2: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47855 )
Change subject: mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC ......................................................................
mb/google/volteer/var/elemi: Add H5ANAG6NCJR-XNC
Add H5ANAG6NCJR-XNC.
BUG=b:165461530 BRANCH=volteer TEST=emerge-volteer coreboot
Change-Id: I827158ce0abe764f1e3b5de46abf50dc148a6ff0 Signed-off-by: Wisley Chen wisley.chen@quanta.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47855 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc M src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt M src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt 3 files changed, 3 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc b/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc index 2685fcd..0a9e3f9 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc +++ b/src/mainboard/google/volteer/variants/elemi/memory/Makefile.inc @@ -5,3 +5,4 @@ SPD_SOURCES += ddr4-spd-2.hex # ID = 0(0b0000) Parts = H5ANAG6NCMR-XNC SPD_SOURCES += ddr4-spd-7.hex # ID = 1(0b0001) Parts = MT40A1G16KD-062E:E, K4AAG165WA-BCWE SPD_SOURCES += ddr4-spd-1.hex # ID = 2(0b0010) Parts = H5AN8G6NDJR-XNC, MT40A512M16TB-062E:J, K4A8G165WC-BCWE +SPD_SOURCES += ddr4-spd-9.hex # ID = 3(0b0011) Parts = H5ANAG6NCJR-XNC diff --git a/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt index c892d9b..e85149b 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt +++ b/src/mainboard/google/volteer/variants/elemi/memory/dram_id.generated.txt @@ -5,3 +5,4 @@ H5AN8G6NDJR-XNC 2 (0010) MT40A512M16TB-062E:J 2 (0010) K4A8G165WC-BCWE 2 (0010) +H5ANAG6NCJR-XNC 3 (0011) diff --git a/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt index 939d85f..b110e92 100644 --- a/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt +++ b/src/mainboard/google/volteer/variants/elemi/memory/mem_list_variant.txt @@ -4,3 +4,4 @@ H5AN8G6NDJR-XNC MT40A512M16TB-062E:J K4A8G165WC-BCWE +H5ANAG6NCJR-XNC
-
Chen Wisley (Code Review) -
Patrick Georgi (Code Review)
-
Tim Wawrzynczak (Code Review)