Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36527 )
Change subject: timestamps: COLLECT_TIMESTAMPS is mostly optional ......................................................................
Patch Set 4: -Code-Review
(4 comments)
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@14 PS3, Line 14: the use of get_us_since_boot() with COLLECT_TIMESTAMPS=n.
The code changes from 'has 5 seconds from power-on elapsed' to 'lets wait here for 5 seconds'.
Done
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@15 PS3, Line 15: We could implement get_us_since_boot() over monotonic timer.
Ya. It's partially my fault, I think. […]
Ack
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo... File src/mainboard/intel/galileo/Kconfig:
https://review.coreboot.org/c/coreboot/+/36527/3/src/mainboard/intel/galileo... PS3, Line 109: select COLLECT_TIMESTAMPS
I'm not sure what the dependency is for CYRPTO_SHIELD necessarily. […]
Done
https://review.coreboot.org/c/coreboot/+/36527/3/src/vendorcode/google/chrom... File src/vendorcode/google/chromeos/Kconfig:
https://review.coreboot.org/c/coreboot/+/36527/3/src/vendorcode/google/chrom... PS3, Line 25: select COLLECT_TIMESTAMPS
This needs to stay.
Done
-
Kyösti Mälkki (Code Review)