Attention is currently required from: Nico Huber, Patrick Rudolph, Tim Wawrzynczak, Subrata Banik, Andrey Petrov, Nathaniel L Desimone.
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49899 )
Change subject: soc/intel/*: Update microcode as specified for MP-init
......................................................................
Patch Set 13:
(1 comment)
File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/49899/comment/fc36d69c_be8f401f
PS13, Line 70: PRMRR
PRMRR isn't currently configured on those platforms, so a second microcode update isn't required at all?
Well, "not configured" would look different ;)
src/soc/intel/tigerlake/romstage/fsp_params.c: m_cfg->PrmrrSize = get_valid_prmrr_size();
src/soc/intel/icelake/romstage/fsp_params.c: m_cfg->PrmrrSize = get_valid_prmrr_size();
src/soc/intel/alderlake/romstage/fsp_params.c: m_cfg->PrmrrSize = get_valid_prmrr_size();
However, they don't select SOC_INTEL_COMMON_BLOCK_SGX, so PrmrrSize will be zero. When any board sets enable_c6dram=1, Fsp set PrmrrSize=1MB.
CpuMpPpi is used (SkipMpInit=0), FSP handles the microcode reload at "End of PEI", so coreboot doesn't have to do that.
When we want to revive SkipMpInit=1, we'll need to do the reload.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49899
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf2b009ac9dd7cd462abe0f787f27b09feb6ec5b
Gerrit-Change-Number: 49899
Gerrit-PatchSet: 13
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Comment-Date: Wed, 10 Feb 2021 23:19:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment