Change in coreboot[master]: security/intel/txt: Fix logging - coreboot-gerrit

3 Mar 2021


      Attention is currently required from: Christian Walter, Arthur Heymans, Patrick Rudolph.
Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51100 )
Change subject: security/intel/txt: Fix logging
......................................................................
Patch Set 1:
(1 comment)
File src/security/intel/txt/logging.c:
https://review.coreboot.org/c/coreboot/+/51100/comment/80edb370_3b9b113d 
PS1, Line 96: intel_txt_log_acm_error
TXT_BIOSACM_ERRORCODE and TXT_ERROR register have different encoding, thus using the same functions to decode seem wrong.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51100
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9c7140c7d51605e2708cbbc4a79d3ac37965656
Gerrit-Change-Number: 51100
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter christian.walter@9elements.com
Gerrit-Reviewer: Patrick Rudolph patrick.rudolph@9elements.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph siro@das-labor.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Christian Walter christian.walter@9elements.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Comment-Date: Wed, 03 Mar 2021 08:13:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment