Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30500 )
Change subject: [WIP]arch/x86/postcar: Add x86_64 support ......................................................................
Patch Set 1:
(3 comments)
https://review.coreboot.org/#/c/30500/1/src/arch/x86/exit_car.S File src/arch/x86/exit_car.S:
https://review.coreboot.org/#/c/30500/1/src/arch/x86/exit_car.S@110 PS1, Line 110: pop %rbx
Just curious, are you forced to use %rbx instead of %eax here. […]
yes 64bit is fine, it holds both the maximum variable mtrrs and the count of mtrrs to pop from stack
https://review.coreboot.org/#/c/30500/1/src/arch/x86/exit_car.S@111 PS1, Line 111: test %rbx, %rbx
Can't you test %ebx? For all except pop's below, why use 64bit register mnemonics %rax when %eax sho […]
Ack
https://review.coreboot.org/#/c/30500/1/src/arch/x86/exit_car.S@114 PS1, Line 114: xor %rbx, %rbx
%rdx ?
Ack
-
Patrick Rudolph (Code Review)