Attention is currently required from: Raul Rangel, Martin Roth. Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57782 )
Change subject: mb/google/guybrush: enable ACPIMMIO decode in mb_set_up_early_espi ......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/guybrush/bootblock.c:
https://review.coreboot.org/c/coreboot/+/57782/comment/eda8c2a7_56f02cf5 PS1, Line 30: enable_acpimmio_decode_pm04
Can we fix most of this by moving the espi init stuff in bootblock_mainboard_early_init out into the […]
yeah, moving the enable_acpimmio_decode_pm04 call from fch_pre_init which gets called in bootblock_soc_early_init to somewhere in bootblock_c_entry might be a good idea. i'll have a look