HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Remove unneeded 'include <gpio.h>' ......................................................................
src: Remove unneeded 'include <gpio.h>'
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/cheza/board.h M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/eve/bootblock.c M src/mainboard/google/foster/boardid.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/cdp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/nyan_big/boardid.c M src/mainboard/google/nyan_blaze/boardid.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8183/gpio.c M src/soc/nvidia/tegra124/chip.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/uart.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c 66 files changed, 0 insertions(+), 66 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/1
diff --git a/src/mainboard/google/cheza/board.h b/src/mainboard/google/cheza/board.h index f83ca06..d9ebdd9 100644 --- a/src/mainboard/google/cheza/board.h +++ b/src/mainboard/google/cheza/board.h @@ -16,7 +16,6 @@ #ifndef __COREBOOT_SRC_MAINBOARD_GOOGLE_CHEZA_BOARD_H #define __COREBOOT_SRC_MAINBOARD_GOOGLE_CHEZA_BOARD_H
-#include <gpio.h> #include <soc/gpio.h>
#define GPIO_EC_IN_RW GPIO(11) diff --git a/src/mainboard/google/dragonegg/smihandler.c b/src/mainboard/google/dragonegg/smihandler.c index 9c72cb6..ef11835 100644 --- a/src/mainboard/google/dragonegg/smihandler.c +++ b/src/mainboard/google/dragonegg/smihandler.c @@ -15,7 +15,6 @@
#include <cpu/x86/smm.h> #include <ec/google/chromeec/smm.h> -#include <gpio.h> #include <soc/gpio.h> #include <soc/smm.h> #include <variant/ec.h> diff --git a/src/mainboard/google/eve/bootblock.c b/src/mainboard/google/eve/bootblock.c index 5e92bb0..079144b 100644 --- a/src/mainboard/google/eve/bootblock.c +++ b/src/mainboard/google/eve/bootblock.c @@ -16,7 +16,6 @@
#include <bootblock_common.h> #include <ec/google/chromeec/ec.h> -#include <gpio.h> #include <soc/gpio.h> #include "gpio.h"
diff --git a/src/mainboard/google/foster/boardid.c b/src/mainboard/google/foster/boardid.c index ed37bab..4d77722 100644 --- a/src/mainboard/google/foster/boardid.c +++ b/src/mainboard/google/foster/boardid.c @@ -15,7 +15,6 @@ */
#include <boardid.h> -#include <gpio.h>
uint32_t board_id(void) { diff --git a/src/mainboard/google/foster/chromeos.c b/src/mainboard/google/foster/chromeos.c index 7ce1300..5fe5c07 100644 --- a/src/mainboard/google/foster/chromeos.c +++ b/src/mainboard/google/foster/chromeos.c @@ -17,7 +17,6 @@ #include <boot/coreboot_tables.h> #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/ec_commands.h> -#include <gpio.h> #include <string.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/google/gale/blsp.c b/src/mainboard/google/gale/blsp.c index 2bc562a..ebc9525 100644 --- a/src/mainboard/google/gale/blsp.c +++ b/src/mainboard/google/gale/blsp.c @@ -27,7 +27,6 @@ * SUCH DAMAGE. */
-#include <gpio.h> #include <soc/gpio.h> #include <soc/blsp.h> #include <soc/qup.h> diff --git a/src/mainboard/google/gale/cdp.c b/src/mainboard/google/gale/cdp.c index 11a0f68..7c159a6 100644 --- a/src/mainboard/google/gale/cdp.c +++ b/src/mainboard/google/gale/cdp.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <gpio.h> #include <soc/cdp.h> #include <soc/ebi2.h> #include <soc/clock.h> diff --git a/src/mainboard/google/gale/mainboard.c b/src/mainboard/google/gale/mainboard.c index 8025374..46a699e 100644 --- a/src/mainboard/google/gale/mainboard.c +++ b/src/mainboard/google/gale/mainboard.c @@ -17,7 +17,6 @@ #include <boardid.h> #include <boot/coreboot_tables.h> #include <device/device.h> -#include <gpio.h> #include <soc/clock.h> #include <soc/soc_services.h> #include <soc/usb.h> diff --git a/src/mainboard/google/glados/smihandler.c b/src/mainboard/google/glados/smihandler.c index a4a1cca..e7e2740 100644 --- a/src/mainboard/google/glados/smihandler.c +++ b/src/mainboard/google/glados/smihandler.c @@ -20,7 +20,6 @@ #include <cpu/x86/smm.h> #include <elog.h> #include <ec/google/chromeec/smm.h> -#include <gpio.h> #include <soc/iomap.h> #include <soc/nvs.h> #include <soc/pm.h> diff --git a/src/mainboard/google/glados/spd/spd.c b/src/mainboard/google/glados/spd/spd.c index 9503582..ab7eca5 100644 --- a/src/mainboard/google/glados/spd/spd.c +++ b/src/mainboard/google/glados/spd/spd.c @@ -16,7 +16,6 @@
#include <cbfs.h> #include <console/console.h> -#include <gpio.h> #include <soc/gpio.h> #include <soc/romstage.h> #include <string.h> diff --git a/src/mainboard/google/gru/board.h b/src/mainboard/google/gru/board.h index acf3fb9..7863823 100644 --- a/src/mainboard/google/gru/board.h +++ b/src/mainboard/google/gru/board.h @@ -18,7 +18,6 @@ #define __COREBOOT_SRC_MAINBOARD_GOOGLE_GRU_BOARD_H
#include <assert.h> -#include <gpio.h>
#define GPIO_POWEROFF GPIO(1, A, 6) #define GPIO_RESET GPIO(0, B, 3) diff --git a/src/mainboard/google/gru/sdram_configs.c b/src/mainboard/google/gru/sdram_configs.c index 5e9e15f..38bd598 100644 --- a/src/mainboard/google/gru/sdram_configs.c +++ b/src/mainboard/google/gru/sdram_configs.c @@ -16,7 +16,6 @@ #include <boardid.h> #include <cbfs.h> #include <console/console.h> -#include <gpio.h> #include <soc/sdram.h> #include <string.h> #include <types.h> diff --git a/src/mainboard/google/nyan_big/boardid.c b/src/mainboard/google/nyan_big/boardid.c index 2a2911c..039b0f8 100644 --- a/src/mainboard/google/nyan_big/boardid.c +++ b/src/mainboard/google/nyan_big/boardid.c @@ -15,7 +15,6 @@
#include <boardid.h> #include <console/console.h> -#include <gpio.h> #include <stdlib.h>
uint32_t board_id(void) diff --git a/src/mainboard/google/nyan_blaze/boardid.c b/src/mainboard/google/nyan_blaze/boardid.c index 2a2911c..039b0f8 100644 --- a/src/mainboard/google/nyan_blaze/boardid.c +++ b/src/mainboard/google/nyan_blaze/boardid.c @@ -15,7 +15,6 @@
#include <boardid.h> #include <console/console.h> -#include <gpio.h> #include <stdlib.h>
uint32_t board_id(void) diff --git a/src/mainboard/google/oak/tpm_tis.c b/src/mainboard/google/oak/tpm_tis.c index 303cfc7..aa78781 100644 --- a/src/mainboard/google/oak/tpm_tis.c +++ b/src/mainboard/google/oak/tpm_tis.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <gpio.h> #include <security/tpm/tis.h>
#include "gpio.h" diff --git a/src/mainboard/google/octopus/variants/bloog/gpio.c b/src/mainboard/google/octopus/variants/bloog/gpio.c index cf3bc4c..5e4ba2e 100644 --- a/src/mainboard/google/octopus/variants/bloog/gpio.c +++ b/src/mainboard/google/octopus/variants/bloog/gpio.c @@ -15,7 +15,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h>
static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/bobba/gpio.c b/src/mainboard/google/octopus/variants/bobba/gpio.c index 6bfe54a..01407b2 100644 --- a/src/mainboard/google/octopus/variants/bobba/gpio.c +++ b/src/mainboard/google/octopus/variants/bobba/gpio.c @@ -16,7 +16,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <boardid.h> -#include <gpio.h> #include <soc/gpio.h>
static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/casta/gpio.c b/src/mainboard/google/octopus/variants/casta/gpio.c index 3a9a441..9332fb4 100644 --- a/src/mainboard/google/octopus/variants/casta/gpio.c +++ b/src/mainboard/google/octopus/variants/casta/gpio.c @@ -16,7 +16,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <boardid.h> -#include <gpio.h> #include <soc/gpio.h>
static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/fleex/gpio.c b/src/mainboard/google/octopus/variants/fleex/gpio.c index d2d0d64..dd3083f 100644 --- a/src/mainboard/google/octopus/variants/fleex/gpio.c +++ b/src/mainboard/google/octopus/variants/fleex/gpio.c @@ -16,7 +16,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <boardid.h> -#include <gpio.h> #include <soc/gpio.h>
static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/garg/gpio.c b/src/mainboard/google/octopus/variants/garg/gpio.c index 90601ce..634fe98 100644 --- a/src/mainboard/google/octopus/variants/garg/gpio.c +++ b/src/mainboard/google/octopus/variants/garg/gpio.c @@ -16,7 +16,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <boardid.h> -#include <gpio.h> #include <soc/gpio.h>
enum { diff --git a/src/mainboard/google/octopus/variants/meep/gpio.c b/src/mainboard/google/octopus/variants/meep/gpio.c index 7b47bf1..eef4743 100644 --- a/src/mainboard/google/octopus/variants/meep/gpio.c +++ b/src/mainboard/google/octopus/variants/meep/gpio.c @@ -15,7 +15,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h>
static const struct pad_config default_override_table[] = { diff --git a/src/mainboard/google/octopus/variants/phaser/gpio.c b/src/mainboard/google/octopus/variants/phaser/gpio.c index 281bde0..a392fcd 100644 --- a/src/mainboard/google/octopus/variants/phaser/gpio.c +++ b/src/mainboard/google/octopus/variants/phaser/gpio.c @@ -16,7 +16,6 @@ #include <baseboard/gpio.h> #include <baseboard/variants.h> #include <boardid.h> -#include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h>
diff --git a/src/mainboard/google/octopus/variants/yorp/gpio.c b/src/mainboard/google/octopus/variants/yorp/gpio.c index 5719888..479a942 100644 --- a/src/mainboard/google/octopus/variants/yorp/gpio.c +++ b/src/mainboard/google/octopus/variants/yorp/gpio.c @@ -15,7 +15,6 @@
#include <baseboard/gpio.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h>
/* GPIOs needed prior to ramstage. */ diff --git a/src/mainboard/google/poppy/smihandler.c b/src/mainboard/google/poppy/smihandler.c index 4f45687..5bc5bc3 100644 --- a/src/mainboard/google/poppy/smihandler.c +++ b/src/mainboard/google/poppy/smihandler.c @@ -17,7 +17,6 @@ #include <ec/google/chromeec/ec.h> #include <ec/google/chromeec/smm.h> #include <elog.h> -#include <gpio.h> #include <soc/gpio.h> #include <soc/smm.h>
diff --git a/src/mainboard/google/reef/mainboard.c b/src/mainboard/google/reef/mainboard.c index 20b6a26..fca47dd 100644 --- a/src/mainboard/google/reef/mainboard.c +++ b/src/mainboard/google/reef/mainboard.c @@ -19,7 +19,6 @@ #include <console/console.h> #include <device/device.h> #include <ec/ec.h> -#include <gpio.h> #include <nhlt.h> #include <smbios.h> #include <soc/gpio.h> diff --git a/src/mainboard/google/reef/variants/baseboard/nhlt.c b/src/mainboard/google/reef/variants/baseboard/nhlt.c index f2ef80f..55cca0b 100644 --- a/src/mainboard/google/reef/variants/baseboard/nhlt.c +++ b/src/mainboard/google/reef/variants/baseboard/nhlt.c @@ -17,7 +17,6 @@ #include <console/console.h> #include <nhlt.h> #include <soc/nhlt.h> -#include <gpio.h> #include <baseboard/gpio.h>
void __weak variant_nhlt_init(struct nhlt *nhlt) diff --git a/src/mainboard/google/reef/variants/pyro/memory.c b/src/mainboard/google/reef/variants/pyro/memory.c index 71ee060..340da5c 100644 --- a/src/mainboard/google/reef/variants/pyro/memory.c +++ b/src/mainboard/google/reef/variants/pyro/memory.c @@ -14,7 +14,6 @@ */
#include <baseboard/variants.h> -#include <gpio.h> #include <soc/meminit.h> #include <variant/gpio.h>
diff --git a/src/mainboard/google/smaug/gpio.h b/src/mainboard/google/smaug/gpio.h index bf6fd53..0352c4f 100644 --- a/src/mainboard/google/smaug/gpio.h +++ b/src/mainboard/google/smaug/gpio.h @@ -16,7 +16,6 @@ #ifndef __MAINBOARD_GOOGLE_SMAUG_GPIO_H__ #define __MAINBOARD_GOOGLE_SMAUG_GPIO_H__
-#include <gpio.h> #include <base3.h>
/* Board ID definitions. */ diff --git a/src/mainboard/google/storm/boardid.c b/src/mainboard/google/storm/boardid.c index 87f6d2a..f73e464 100644 --- a/src/mainboard/google/storm/boardid.c +++ b/src/mainboard/google/storm/boardid.c @@ -14,7 +14,6 @@ */
#include <boardid.h> -#include <gpio.h> #include <console/console.h> #include <stdlib.h>
diff --git a/src/mainboard/google/storm/cdp.c b/src/mainboard/google/storm/cdp.c index 3c27491..efded9e 100644 --- a/src/mainboard/google/storm/cdp.c +++ b/src/mainboard/google/storm/cdp.c @@ -14,7 +14,6 @@ */
#include <device/mmio.h> -#include <gpio.h> #include <soc/cdp.h> #include <soc/ebi2.h> #include <soc/clock.h> diff --git a/src/mainboard/google/urara/chromeos.c b/src/mainboard/google/urara/chromeos.c index 3f7ec32..e9148a3 100644 --- a/src/mainboard/google/urara/chromeos.c +++ b/src/mainboard/google/urara/chromeos.c @@ -16,7 +16,6 @@ #include <boot/coreboot_tables.h> #include <bootmode.h> #include <console/console.h> -#include <gpio.h>
int get_write_protect_state(void) { diff --git a/src/mainboard/google/veyron/board.h b/src/mainboard/google/veyron/board.h index e6c300c..a83dd85 100644 --- a/src/mainboard/google/veyron/board.h +++ b/src/mainboard/google/veyron/board.h @@ -17,7 +17,6 @@ #define __MAINBOARD_GOOGLE_VEYRON_BOARD_H
#include <boardid.h> -#include <gpio.h>
#define GPIO_BACKLIGHT GPIO(7, A, 2) #define GPIO_RESET GPIO(0, B, 5) diff --git a/src/mainboard/google/veyron/sdram_configs.c b/src/mainboard/google/veyron/sdram_configs.c index 291bc33..0246d0d 100644 --- a/src/mainboard/google/veyron/sdram_configs.c +++ b/src/mainboard/google/veyron/sdram_configs.c @@ -14,7 +14,6 @@ */ #include <boardid.h> #include <console/console.h> -#include <gpio.h> #include <soc/sdram.h> #include <types.h>
diff --git a/src/mainboard/google/veyron_mickey/board.h b/src/mainboard/google/veyron_mickey/board.h index c99146f..4e7be43 100644 --- a/src/mainboard/google/veyron_mickey/board.h +++ b/src/mainboard/google/veyron_mickey/board.h @@ -17,7 +17,6 @@ #define __MAINBOARD_GOOGLE_VEYRON_MICKEY_BOARD_H
#include <boardid.h> -#include <gpio.h>
#define GPIO_RESET GPIO(0, B, 5)
diff --git a/src/mainboard/google/veyron_mickey/sdram_configs.c b/src/mainboard/google/veyron_mickey/sdram_configs.c index 291bc33..0246d0d 100644 --- a/src/mainboard/google/veyron_mickey/sdram_configs.c +++ b/src/mainboard/google/veyron_mickey/sdram_configs.c @@ -14,7 +14,6 @@ */ #include <boardid.h> #include <console/console.h> -#include <gpio.h> #include <soc/sdram.h> #include <types.h>
diff --git a/src/mainboard/google/veyron_rialto/board.h b/src/mainboard/google/veyron_rialto/board.h index def5246..0a9d9e7 100644 --- a/src/mainboard/google/veyron_rialto/board.h +++ b/src/mainboard/google/veyron_rialto/board.h @@ -17,7 +17,6 @@ #define __MAINBOARD_GOOGLE_VEYRON_RIALTO_BOARD_H
#include <boardid.h> -#include <gpio.h>
#define GPIO_RESET GPIO(0, B, 5)
diff --git a/src/mainboard/google/veyron_rialto/sdram_configs.c b/src/mainboard/google/veyron_rialto/sdram_configs.c index 8eae71d..0d68a96 100644 --- a/src/mainboard/google/veyron_rialto/sdram_configs.c +++ b/src/mainboard/google/veyron_rialto/sdram_configs.c @@ -14,7 +14,6 @@ */ #include <boardid.h> #include <console/console.h> -#include <gpio.h> #include <soc/sdram.h> #include <types.h>
diff --git a/src/mainboard/intel/cannonlake_rvp/chromeos.c b/src/mainboard/intel/cannonlake_rvp/chromeos.c index 44254bc..d1186bb 100644 --- a/src/mainboard/intel/cannonlake_rvp/chromeos.c +++ b/src/mainboard/intel/cannonlake_rvp/chromeos.c @@ -15,7 +15,6 @@
#include <arch/acpi.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/coffeelake_rvp/chromeos.c b/src/mainboard/intel/coffeelake_rvp/chromeos.c index a581217..ad03823 100644 --- a/src/mainboard/intel/coffeelake_rvp/chromeos.c +++ b/src/mainboard/intel/coffeelake_rvp/chromeos.c @@ -15,7 +15,6 @@
#include <arch/acpi.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h> #include <vendorcode/google/chromeos/chromeos.h>
diff --git a/src/mainboard/intel/coffeelake_rvp/memory.c b/src/mainboard/intel/coffeelake_rvp/memory.c index b093a20..114a869 100644 --- a/src/mainboard/intel/coffeelake_rvp/memory.c +++ b/src/mainboard/intel/coffeelake_rvp/memory.c @@ -16,7 +16,6 @@
#include <baseboard/variants.h> #include <baseboard/gpio.h> -#include <gpio.h> #include <soc/cnl_memcfg_init.h>
static const struct cnl_mb_cfg baseboard_memcfg_cfg = { diff --git a/src/mainboard/intel/glkrvp/chromeos.c b/src/mainboard/intel/glkrvp/chromeos.c index 4edd4a0..75c928d 100644 --- a/src/mainboard/intel/glkrvp/chromeos.c +++ b/src/mainboard/intel/glkrvp/chromeos.c @@ -16,7 +16,6 @@ #include <baseboard/variants.h> #include <boot/coreboot_tables.h> #include <ec/google/chromeec/ec.h> -#include <gpio.h> #include <vendorcode/google/chromeos/chromeos.h> #include <soc/gpio.h> #include <variant/gpio.h> diff --git a/src/mainboard/intel/glkrvp/variants/baseboard/memory.c b/src/mainboard/intel/glkrvp/variants/baseboard/memory.c index 1173ee4..8663ed8 100644 --- a/src/mainboard/intel/glkrvp/variants/baseboard/memory.c +++ b/src/mainboard/intel/glkrvp/variants/baseboard/memory.c @@ -14,7 +14,6 @@ */
#include <baseboard/variants.h> -#include <gpio.h> #include <soc/meminit.h> #include <variant/gpio.h>
diff --git a/src/mainboard/intel/icelake_rvp/chromeos.c b/src/mainboard/intel/icelake_rvp/chromeos.c index ce8e548..87614b6 100644 --- a/src/mainboard/intel/icelake_rvp/chromeos.c +++ b/src/mainboard/intel/icelake_rvp/chromeos.c @@ -15,7 +15,6 @@
#include <arch/acpi.h> #include <baseboard/variants.h> -#include <gpio.h> #include <soc/gpio.h> #include <variant/gpio.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/kblrvp/chromeos.c b/src/mainboard/intel/kblrvp/chromeos.c index ff93d27..42bb74d 100644 --- a/src/mainboard/intel/kblrvp/chromeos.c +++ b/src/mainboard/intel/kblrvp/chromeos.c @@ -16,7 +16,6 @@
#include <device/device.h> #include <device/pci.h> -#include <gpio.h> #include <soc/gpio.h> #include <ec/google/chromeec/ec.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/kblrvp/mainboard.c b/src/mainboard/intel/kblrvp/mainboard.c index 78c7ae4..3ef3c512 100644 --- a/src/mainboard/intel/kblrvp/mainboard.c +++ b/src/mainboard/intel/kblrvp/mainboard.c @@ -17,7 +17,6 @@
#include <arch/acpi.h> #include <device/device.h> -#include <gpio.h> #include <stdlib.h> #include <soc/nhlt.h> #include <vendorcode/google/chromeos/chromeos.h> diff --git a/src/mainboard/intel/kblrvp/romstage.c b/src/mainboard/intel/kblrvp/romstage.c index 0385e29..34aa405 100644 --- a/src/mainboard/intel/kblrvp/romstage.c +++ b/src/mainboard/intel/kblrvp/romstage.c @@ -16,7 +16,6 @@ #include <cbfs.h> #include <console/console.h> #include <fsp/api.h> -#include <gpio.h> #include "gpio.h" #include <soc/romstage.h> #include <soc/gpio.h> diff --git a/src/mainboard/intel/kblrvp/spd/spd.h b/src/mainboard/intel/kblrvp/spd/spd.h index c24baa0..33aa475 100644 --- a/src/mainboard/intel/kblrvp/spd/spd.h +++ b/src/mainboard/intel/kblrvp/spd/spd.h @@ -17,7 +17,6 @@ #ifndef MAINBOARD_SPD_H #define MAINBOARD_SPD_H
-#include <gpio.h> #include <variant/gpio.h>
#define RCOMP_TARGET_PARAMS 0x5 diff --git a/src/mainboard/intel/kunimitsu/romstage.c b/src/mainboard/intel/kunimitsu/romstage.c index f900ca3..28327e8 100644 --- a/src/mainboard/intel/kunimitsu/romstage.c +++ b/src/mainboard/intel/kunimitsu/romstage.c @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
-#include <gpio.h> #include <soc/romstage.h> #include "gpio.h" #include "spd/spd.h" diff --git a/src/mainboard/intel/kunimitsu/romstage_fsp20.c b/src/mainboard/intel/kunimitsu/romstage_fsp20.c index 5364693..ec46ec2 100644 --- a/src/mainboard/intel/kunimitsu/romstage_fsp20.c +++ b/src/mainboard/intel/kunimitsu/romstage_fsp20.c @@ -14,7 +14,6 @@ */
#include <fsp/api.h> -#include <gpio.h> #include "gpio.h" #include <soc/romstage.h> #include <soc/gpio.h> diff --git a/src/soc/cavium/cn81xx/include/soc/gpio.h b/src/soc/cavium/cn81xx/include/soc/gpio.h index 6986482..7c17547 100644 --- a/src/soc/cavium/cn81xx/include/soc/gpio.h +++ b/src/soc/cavium/cn81xx/include/soc/gpio.h @@ -20,7 +20,6 @@ #include <types.h>
typedef u32 gpio_t; -#include <gpio.h>
/* The following functions must be implemented by SoC/board code. */
diff --git a/src/soc/intel/skylake/uart.c b/src/soc/intel/skylake/uart.c index 8b7c99e..9dd23de 100644 --- a/src/soc/intel/skylake/uart.c +++ b/src/soc/intel/skylake/uart.c @@ -16,7 +16,6 @@
#include <console/console.h> #include <device/pci_def.h> -#include <gpio.h> #include <intelblocks/lpss.h> #include <intelblocks/pcr.h> #include <intelblocks/uart.h> diff --git a/src/soc/mediatek/mt8173/gpio.c b/src/soc/mediatek/mt8173/gpio.c index a29c1c1..ec96bdf 100644 --- a/src/soc/mediatek/mt8173/gpio.c +++ b/src/soc/mediatek/mt8173/gpio.c @@ -14,7 +14,6 @@ */ #include <device/mmio.h> #include <assert.h> -#include <gpio.h> #include <types.h>
enum { diff --git a/src/soc/mediatek/mt8183/gpio.c b/src/soc/mediatek/mt8183/gpio.c index 3eccfbd..36aa28c5 100644 --- a/src/soc/mediatek/mt8183/gpio.c +++ b/src/soc/mediatek/mt8183/gpio.c @@ -14,7 +14,6 @@ */
#include <device/mmio.h> -#include <gpio.h> #include <assert.h> #include <soc/spi.h>
diff --git a/src/soc/nvidia/tegra124/chip.h b/src/soc/nvidia/tegra124/chip.h index 7e930d1..2c260dc 100644 --- a/src/soc/nvidia/tegra124/chip.h +++ b/src/soc/nvidia/tegra124/chip.h @@ -16,7 +16,6 @@ #ifndef __SOC_NVIDIA_TEGRA124_CHIP_H__ #define __SOC_NVIDIA_TEGRA124_CHIP_H__ #include <arch/cache.h> -#include <gpio.h> #include <soc/addressmap.h>
#define EFAULT 1 diff --git a/src/soc/qualcomm/ipq40xx/spi.c b/src/soc/qualcomm/ipq40xx/spi.c index b68e1cb..3ce46d2 100644 --- a/src/soc/qualcomm/ipq40xx/spi.c +++ b/src/soc/qualcomm/ipq40xx/spi.c @@ -30,7 +30,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <gpio.h> #include <soc/iomap.h> #include <soc/spi.h> #include <stdlib.h> diff --git a/src/soc/qualcomm/ipq40xx/uart.c b/src/soc/qualcomm/ipq40xx/uart.c index eb3731b..9f92347 100644 --- a/src/soc/qualcomm/ipq40xx/uart.c +++ b/src/soc/qualcomm/ipq40xx/uart.c @@ -32,7 +32,6 @@ #include <boot/coreboot_tables.h> #include <console/uart.h> #include <delay.h> -#include <gpio.h> #include <soc/clock.h> #include <soc/blsp.h> #include <soc/ipq_uart.h> diff --git a/src/soc/qualcomm/ipq806x/spi.c b/src/soc/qualcomm/ipq806x/spi.c index 2657b9c..e749ba6 100644 --- a/src/soc/qualcomm/ipq806x/spi.c +++ b/src/soc/qualcomm/ipq806x/spi.c @@ -16,7 +16,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <gpio.h> #include <soc/iomap.h> #include <soc/spi.h> #include <stdlib.h> diff --git a/src/soc/qualcomm/ipq806x/uart.c b/src/soc/qualcomm/ipq806x/uart.c index 66c3103..aefaf31 100644 --- a/src/soc/qualcomm/ipq806x/uart.c +++ b/src/soc/qualcomm/ipq806x/uart.c @@ -35,7 +35,6 @@ #include <boot/coreboot_tables.h> #include <console/uart.h> #include <delay.h> -#include <gpio.h> #include <soc/clock.h> #include <soc/gsbi.h> #include <soc/ipq_uart.h> diff --git a/src/soc/qualcomm/qcs405/spi.c b/src/soc/qualcomm/qcs405/spi.c index 13b9dae..c205e6d 100644 --- a/src/soc/qualcomm/qcs405/spi.c +++ b/src/soc/qualcomm/qcs405/spi.c @@ -30,7 +30,6 @@ #include <device/mmio.h> #include <console/console.h> #include <delay.h> -#include <gpio.h> #include <soc/iomap.h> #include <soc/spi.h> #include <soc/clock.h> diff --git a/src/soc/qualcomm/qcs405/uart.c b/src/soc/qualcomm/qcs405/uart.c index 4a43312..2b951ed 100644 --- a/src/soc/qualcomm/qcs405/uart.c +++ b/src/soc/qualcomm/qcs405/uart.c @@ -33,7 +33,6 @@ #include <console/console.h> #include <console/uart.h> #include <delay.h> -#include <gpio.h> #include <soc/clock.h> #include <soc/blsp.h> #include <soc/uart.h> diff --git a/src/soc/rockchip/rk3288/display.c b/src/soc/rockchip/rk3288/display.c index 04a5992..729cfa6 100644 --- a/src/soc/rockchip/rk3288/display.c +++ b/src/soc/rockchip/rk3288/display.c @@ -19,7 +19,6 @@ #include <device/device.h> #include <delay.h> #include <edid.h> -#include <gpio.h> #include <stdlib.h> #include <stddef.h> #include <string.h> diff --git a/src/soc/rockchip/rk3288/gpio.c b/src/soc/rockchip/rk3288/gpio.c index 0f9d85c..eac1f5c 100644 --- a/src/soc/rockchip/rk3288/gpio.c +++ b/src/soc/rockchip/rk3288/gpio.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <gpio.h> #include <soc/gpio.h> #include <soc/grf.h> #include <soc/pmu.h> diff --git a/src/soc/rockchip/rk3288/soc.c b/src/soc/rockchip/rk3288/soc.c index bda9553..335b578 100644 --- a/src/soc/rockchip/rk3288/soc.c +++ b/src/soc/rockchip/rk3288/soc.c @@ -17,7 +17,6 @@ #include <bootmode.h> #include <console/console.h> #include <device/device.h> -#include <gpio.h> #include <soc/display.h> #include <soc/soc.h> #include <soc/sdram.h> diff --git a/src/soc/rockchip/rk3399/display.c b/src/soc/rockchip/rk3399/display.c index e2e9f7d..3a49dcc 100644 --- a/src/soc/rockchip/rk3399/display.c +++ b/src/soc/rockchip/rk3399/display.c @@ -20,7 +20,6 @@ #include <device/device.h> #include <delay.h> #include <edid.h> -#include <gpio.h> #include <stdlib.h> #include <stddef.h> #include <soc/addressmap.h> diff --git a/src/soc/rockchip/rk3399/gpio.c b/src/soc/rockchip/rk3399/gpio.c index 7fe2c19..8984eaa 100644 --- a/src/soc/rockchip/rk3399/gpio.c +++ b/src/soc/rockchip/rk3399/gpio.c @@ -13,7 +13,6 @@ * GNU General Public License for more details. */
-#include <gpio.h> #include <soc/addressmap.h> #include <soc/gpio.h> #include <soc/grf.h> diff --git a/src/soc/rockchip/rk3399/mipi.c b/src/soc/rockchip/rk3399/mipi.c index 1f3f02c..2898f20 100644 --- a/src/soc/rockchip/rk3399/mipi.c +++ b/src/soc/rockchip/rk3399/mipi.c @@ -18,7 +18,6 @@ #include <delay.h> #include <device/device.h> #include <edid.h> -#include <gpio.h> #include <stdlib.h> #include <string.h> #include <soc/addressmap.h>
Hello Patrick Rudolph, Julius Werner, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#2).
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
src: Use 'include <gpio.h>' when appropriate
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/eve/bootblock.c M src/mainboard/google/foster/boardid.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/cdp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/nyan_big/boardid.c M src/mainboard/google/nyan_blaze/boardid.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/opencellular/elgon/bootblock.c M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8183/gpio.c M src/soc/nvidia/tegra124/chip.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/uart.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c 73 files changed, 9 insertions(+), 66 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/2
Hello Patrick Rudolph, Julius Werner, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#3).
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
src: Use 'include <gpio.h>' when appropriate
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/eve/bootblock.c M src/mainboard/google/foster/boardid.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/cdp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/nyan_big/boardid.c M src/mainboard/google/nyan_blaze/boardid.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8183/gpio.c M src/soc/nvidia/tegra124/chip.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/uart.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c 75 files changed, 23 insertions(+), 65 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/3
Hello Patrick Rudolph, Julius Werner, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#4).
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
src: Use 'include <gpio.h>' when appropriate
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/eve/bootblock.c M src/mainboard/google/foster/boardid.c M src/mainboard/google/foster/chromeos.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/cdp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8183/gpio.c M src/soc/nvidia/tegra124/chip.h M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/ipq806x/spi.c M src/soc/qualcomm/ipq806x/uart.c M src/soc/qualcomm/qcs405/spi.c M src/soc/qualcomm/qcs405/uart.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c 74 files changed, 25 insertions(+), 63 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/4
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
Patch Set 4:
<soc/gpio.h> should never be directly included by any file (other than gpio.h itself). All code using GPIO features should always and only include <gpio.h>, and having access to SoC-specific definitions from there should be implicit.
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
Patch Set 4:
Patch Set 4:
<soc/gpio.h> should never be directly included by any file (other than gpio.h itself). All code using GPIO features should always and only include <gpio.h>, and having access to SoC-specific definitions from there should be implicit.
sounds nice.
by the way, I got this error : /cb-build/coreboot-gerrit.0/GOOGLE_NYAN_BIG/mainboard/google/nyan_big/static.c:14:29: error: 'P2' undeclared here (not in a function) .backlight_vdd_gpio = GPIO(H2),"
and didn't found where 'H2' is defined ....
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
Patch Set 4:
by the way, I got this error : /cb-build/coreboot-gerrit.0/GOOGLE_NYAN_BIG/mainboard/google/nyan_big/static.c:14:29: error: 'P2' undeclared here (not in a function) .backlight_vdd_gpio = GPIO(H2),"
and didn't found where 'H2' is defined ....
The problem is that it doesn't have the GPIO() macro (and therefore thinks it's a function, and therefore thinks the thing inside the parenthesis was a normal identifier, which it isn't). You shouldn't remove it from any chip.h headers, those are special (because they get included in the runtime-generated code from sconfig).
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Use 'include <gpio.h>' when appropriate ......................................................................
Patch Set 4:
(2 comments)
Looks like Jenkins complains because of missing includes.
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/nvidia/tegra124/chi... File src/soc/nvidia/tegra124/chip.h:
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/nvidia/tegra124/chi... PS4, Line 19: You need that
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/qualcomm/ipq806x/ua... File src/soc/qualcomm/ipq806x/uart.c:
https://review.coreboot.org/c/coreboot/+/34233/4/src/soc/qualcomm/ipq806x/ua... PS4, Line 38: You need that
Hello Patrick Rudolph, Julius Werner, Patrick Rudolph, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#5).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>. <gpio.h> is supposed to provide indirect include <soc/gpio.h>.
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/acpi/mainboard.asl M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/acpi/sb_fch.asl M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/acpi/sb_fch.asl M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/apollolake/acpi/gpio.asl M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/include/soc/smm.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/icelake/chip.h M src/soc/intel/icelake/include/soc/smm.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/acpi/gpio.asl M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/chip.h M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/chip.h M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/chip.h M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/chip.h M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 307 files changed, 242 insertions(+), 304 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/5
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34233/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34233/5//COMMIT_MSG@10 PS5, Line 10: include <gpio.h>. : <gpio.h> is supposed to provide indirect include <soc/gpio.h>. I would suggest rephrasing this part, emphasizing that <soc/gpio.h> is SoC-specific.
include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#6).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/chip.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/chip.h M src/soc/intel/cannonlake/include/soc/smm.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/icelake/chip.h M src/soc/intel/icelake/include/soc/smm.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/chip.h M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/chip.h M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/chip.h M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/chip.h M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/chip.h M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 302 files changed, 237 insertions(+), 299 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/6
Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#7).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/gpio.h M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/cavium/cn81xx/include/soc/gpio.h M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/include/soc/smm.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/icelake/include/soc/smm.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 294 files changed, 229 insertions(+), 291 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/7
Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#8).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/include/soc/smm.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/fsp_broadwell_de/romstage/romstage.c M src/soc/intel/icelake/include/soc/smm.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/dsi.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 292 files changed, 228 insertions(+), 289 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/8
Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
Patch Set 8: Code-Review+1
Works fine on Facebook FBG1701
Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#9).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 288 files changed, 223 insertions(+), 285 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/9
Hello Werner Zeh, Patrick Rudolph, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#11).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Also, <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/gpio.h M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/gpio.h M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/include/soc/gpio.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/include/soc/gpio.h M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/include/soc/gpio.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/denverton_ns/include/soc/gpio.h M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/include/soc/gpio.h M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/icelake/include/soc/gpio.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 298 files changed, 257 insertions(+), 289 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/11
Hello Werner Zeh, Patrick Rudolph, Vanny E, Huang Jin, Julius Werner, Frans Hendriks, Patrick Rudolph, wvervoorn, Philipp Deppenwiese, build bot (Jenkins), David Guckian,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34233
to look at the new patch set (#12).
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
src: Remove direct 'include <soc/gpio.h>'
Don't directly include <soc/gpio.h>. All code using GPIO features should always and only include <gpio.h>, which should indirectly include the SoC-specific <soc/gpio.h>.
Also, <soc/gpio.h> must typedef a gpio_t that fits in 32 bits.
Change-Id: I570c6fcc889b37297fed7f1e252de1ff1ff632fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/include/gpio.h M src/mainboard/amd/gardenia/gpio.c M src/mainboard/asrock/h110m/bootblock.c M src/mainboard/cavium/cn8100_sff_evb/mainboard.c M src/mainboard/esd/atom15/gpio.c M src/mainboard/esd/atom15/romstage.c M src/mainboard/facebook/fbg1701/gpio.c M src/mainboard/google/auron/chromeos.c M src/mainboard/google/auron/smihandler.c M src/mainboard/google/auron/variants/auron_paine/gpio.c M src/mainboard/google/auron/variants/auron_paine/pei_data.c M src/mainboard/google/auron/variants/auron_paine/spd/spd.c M src/mainboard/google/auron/variants/auron_yuna/gpio.c M src/mainboard/google/auron/variants/auron_yuna/pei_data.c M src/mainboard/google/auron/variants/auron_yuna/spd/spd.c M src/mainboard/google/auron/variants/buddy/gpio.c M src/mainboard/google/auron/variants/buddy/pei_data.c M src/mainboard/google/auron/variants/gandof/gpio.c M src/mainboard/google/auron/variants/gandof/pei_data.c M src/mainboard/google/auron/variants/gandof/spd/spd.c M src/mainboard/google/auron/variants/lulu/gpio.c M src/mainboard/google/auron/variants/lulu/pei_data.c M src/mainboard/google/auron/variants/lulu/spd/spd.c M src/mainboard/google/auron/variants/samus/gpio.c M src/mainboard/google/auron/variants/samus/pei_data.c M src/mainboard/google/auron/variants/samus/spd/spd.c M src/mainboard/google/auron/variants/samus/variant.c M src/mainboard/google/cheza/board.h M src/mainboard/google/cheza/chromeos.c M src/mainboard/google/cyan/chromeos.c M src/mainboard/google/cyan/com_init.c M src/mainboard/google/cyan/smihandler.c M src/mainboard/google/cyan/spd/spd.c M src/mainboard/google/cyan/variants/banon/gpio.c M src/mainboard/google/cyan/variants/celes/gpio.c M src/mainboard/google/cyan/variants/celes/spd_util.c M src/mainboard/google/cyan/variants/cyan/gpio.c M src/mainboard/google/cyan/variants/edgar/gpio.c M src/mainboard/google/cyan/variants/kefka/gpio.c M src/mainboard/google/cyan/variants/reks/gpio.c M src/mainboard/google/cyan/variants/relm/gpio.c M src/mainboard/google/cyan/variants/setzer/gpio.c M src/mainboard/google/cyan/variants/setzer/spd_util.c M src/mainboard/google/cyan/variants/terra/gpio.c M src/mainboard/google/cyan/variants/ultima/gpio.c M src/mainboard/google/cyan/variants/wizpig/gpio.c M src/mainboard/google/daisy/chromeos.c M src/mainboard/google/daisy/mainboard.c M src/mainboard/google/daisy/memory.c M src/mainboard/google/daisy/romstage.c M src/mainboard/google/daisy/wakeup.c M src/mainboard/google/dragonegg/bootblock.c M src/mainboard/google/dragonegg/chromeos.c M src/mainboard/google/dragonegg/mainboard.c M src/mainboard/google/dragonegg/smihandler.c M src/mainboard/google/dragonegg/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/eve/bootblock.c M src/mainboard/google/eve/chromeos.c M src/mainboard/google/eve/spd/spd.c M src/mainboard/google/fizz/bootblock.c M src/mainboard/google/fizz/chromeos.c M src/mainboard/google/fizz/mainboard.c M src/mainboard/google/fizz/ramstage.c M src/mainboard/google/fizz/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/foster/boardid.c M src/mainboard/google/gale/blsp.c M src/mainboard/google/gale/mainboard.c M src/mainboard/google/glados/bootblock_mainboard.c M src/mainboard/google/glados/chromeos.c M src/mainboard/google/glados/smihandler.c M src/mainboard/google/glados/spd/spd.c M src/mainboard/google/gru/board.h M src/mainboard/google/gru/romstage.c M src/mainboard/google/gru/sdram_configs.c M src/mainboard/google/hatch/bootblock.c M src/mainboard/google/hatch/ramstage.c M src/mainboard/google/hatch/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/jecht/chromeos.c M src/mainboard/google/jecht/smihandler.c M src/mainboard/google/jecht/variants/guado/gpio.c M src/mainboard/google/jecht/variants/guado/pei_data.c M src/mainboard/google/jecht/variants/jecht/gpio.c M src/mainboard/google/jecht/variants/jecht/pei_data.c M src/mainboard/google/jecht/variants/rikku/gpio.c M src/mainboard/google/jecht/variants/rikku/pei_data.c M src/mainboard/google/jecht/variants/tidus/gpio.c M src/mainboard/google/jecht/variants/tidus/pei_data.c M src/mainboard/google/kahlee/bootblock/bootblock.c M src/mainboard/google/kahlee/romstage.c M src/mainboard/google/kahlee/variants/baseboard/gpio.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/kahlee/variants/baseboard/tpm_tis.c M src/mainboard/google/kukui/bootblock.c M src/mainboard/google/kukui/mainboard.c M src/mainboard/google/oak/bootblock.c M src/mainboard/google/oak/tpm_tis.c M src/mainboard/google/octopus/bootblock.c M src/mainboard/google/octopus/chromeos.c M src/mainboard/google/octopus/mainboard.c M src/mainboard/google/octopus/smihandler.c M src/mainboard/google/octopus/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/octopus/variants/bloog/gpio.c M src/mainboard/google/octopus/variants/bobba/gpio.c M src/mainboard/google/octopus/variants/casta/gpio.c M src/mainboard/google/octopus/variants/fleex/gpio.c M src/mainboard/google/octopus/variants/garg/gpio.c M src/mainboard/google/octopus/variants/meep/gpio.c M src/mainboard/google/octopus/variants/phaser/gpio.c M src/mainboard/google/octopus/variants/yorp/gpio.c M src/mainboard/google/peach_pit/chromeos.c M src/mainboard/google/peach_pit/mainboard.c M src/mainboard/google/peach_pit/memory.c M src/mainboard/google/peach_pit/romstage.c M src/mainboard/google/peach_pit/wakeup.c M src/mainboard/google/poppy/bootblock.c M src/mainboard/google/poppy/chromeos.c M src/mainboard/google/poppy/romstage.c M src/mainboard/google/poppy/smihandler.c M src/mainboard/google/poppy/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/rambi/chromeos.c M src/mainboard/google/rambi/mainboard.c M src/mainboard/google/rambi/romstage.c M src/mainboard/google/rambi/variants/banjo/gpio.c M src/mainboard/google/rambi/variants/candy/gpio.c M src/mainboard/google/rambi/variants/clapper/gpio.c M src/mainboard/google/rambi/variants/enguarde/gpio.c M src/mainboard/google/rambi/variants/glimmer/gpio.c M src/mainboard/google/rambi/variants/gnawty/gpio.c M src/mainboard/google/rambi/variants/heli/gpio.c M src/mainboard/google/rambi/variants/kip/gpio.c M src/mainboard/google/rambi/variants/ninja/gpio.c M src/mainboard/google/rambi/variants/orco/gpio.c M src/mainboard/google/rambi/variants/quawks/gpio.c M src/mainboard/google/rambi/variants/rambi/gpio.c M src/mainboard/google/rambi/variants/squawks/gpio.c M src/mainboard/google/rambi/variants/sumo/gpio.c M src/mainboard/google/rambi/variants/swanky/gpio.c M src/mainboard/google/rambi/variants/winky/gpio.c M src/mainboard/google/reef/bootblock.c M src/mainboard/google/reef/chromeos.c M src/mainboard/google/reef/mainboard.c M src/mainboard/google/reef/smihandler.c M src/mainboard/google/reef/variants/baseboard/include/baseboard/variants.h M src/mainboard/google/reef/variants/baseboard/nhlt.c M src/mainboard/google/reef/variants/coral/mainboard.c M src/mainboard/google/reef/variants/pyro/memory.c M src/mainboard/google/sarien/bootblock.c M src/mainboard/google/sarien/chromeos.c M src/mainboard/google/sarien/ramstage.c M src/mainboard/google/sarien/variants/arcada/include/variant/ec.h M src/mainboard/google/sarien/variants/sarien/include/variant/ec.h M src/mainboard/google/smaug/boardid.c M src/mainboard/google/smaug/chromeos.c M src/mainboard/google/smaug/reset.c M src/mainboard/google/storm/boardid.c M src/mainboard/google/storm/cdp.c M src/mainboard/google/storm/gsbi.c M src/mainboard/google/urara/chromeos.c M src/mainboard/google/veyron/board.h M src/mainboard/google/veyron/sdram_configs.c M src/mainboard/google/veyron_mickey/board.h M src/mainboard/google/veyron_mickey/bootblock.c M src/mainboard/google/veyron_mickey/sdram_configs.c M src/mainboard/google/veyron_rialto/board.h M src/mainboard/google/veyron_rialto/bootblock.c M src/mainboard/google/veyron_rialto/sdram_configs.c M src/mainboard/intel/bayleybay_fsp/gpio.c M src/mainboard/intel/bayleybay_fsp/romstage.c M src/mainboard/intel/cannonlake_rvp/bootblock.c M src/mainboard/intel/cannonlake_rvp/chromeos.c M src/mainboard/intel/cannonlake_rvp/mainboard.c M src/mainboard/intel/cannonlake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/coffeelake_rvp/bootblock.c M src/mainboard/intel/coffeelake_rvp/chromeos.c M src/mainboard/intel/coffeelake_rvp/mainboard.c M src/mainboard/intel/coffeelake_rvp/memory.c M src/mainboard/intel/coffeelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/bootblock.c M src/mainboard/intel/glkrvp/chromeos.c M src/mainboard/intel/glkrvp/mainboard.c M src/mainboard/intel/glkrvp/smihandler.c M src/mainboard/intel/glkrvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/glkrvp/variants/baseboard/memory.c M src/mainboard/intel/icelake_rvp/bootblock.c M src/mainboard/intel/icelake_rvp/chromeos.c M src/mainboard/intel/icelake_rvp/mainboard.c M src/mainboard/intel/icelake_rvp/variants/baseboard/include/baseboard/variants.h M src/mainboard/intel/kblrvp/bootblock.c M src/mainboard/intel/kblrvp/chromeos.c M src/mainboard/intel/kblrvp/mainboard.c M src/mainboard/intel/kblrvp/romstage.c M src/mainboard/intel/kblrvp/spd/spd.h M src/mainboard/intel/kunimitsu/bootblock_mainboard.c M src/mainboard/intel/kunimitsu/chromeos.c M src/mainboard/intel/kunimitsu/romstage.c M src/mainboard/intel/kunimitsu/romstage_fsp20.c M src/mainboard/intel/minnowmax/gpio.c M src/mainboard/intel/minnowmax/romstage.c M src/mainboard/intel/saddlebrook/bootblock.c M src/mainboard/intel/saddlebrook/romstage.c M src/mainboard/intel/strago/com_init.c M src/mainboard/intel/strago/gpio.c M src/mainboard/intel/strago/mainboard.c M src/mainboard/intel/strago/smihandler.c M src/mainboard/intel/wtm2/chromeos.c M src/mainboard/intel/wtm2/gpio.c M src/mainboard/intel/wtm2/pei_data.c M src/mainboard/intel/wtm2/romstage.c M src/mainboard/opencellular/elgon/bootblock.c M src/mainboard/opencellular/elgon/death.c M src/mainboard/opencellular/elgon/mainboard.c M src/mainboard/opencellular/rotundu/romstage.c M src/mainboard/opencellular/rotundu/variants/rotundu/gpio.c M src/mainboard/opencellular/rotundu/variants/supabrckv1/gpio.c M src/mainboard/purism/librem_bdw/gpio.c M src/mainboard/siemens/mc_apl1/variants/baseboard/include/baseboard/variants.h M src/mainboard/siemens/mc_bdx1/romstage.c M src/mainboard/siemens/mc_tcu3/gpio.c M src/mainboard/siemens/mc_tcu3/romstage.c M src/soc/amd/common/block/gpio_banks/gpio.c M src/soc/amd/picasso/acpi.c M src/soc/amd/picasso/gpio.c M src/soc/amd/picasso/include/soc/gpio.h M src/soc/amd/picasso/include/soc/i2c.h M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/gpio.h M src/soc/amd/stoneyridge/include/soc/i2c.h M src/soc/cavium/cn81xx/gpio.c M src/soc/intel/apollolake/bootblock/bootblock.c M src/soc/intel/apollolake/include/soc/gpio.h M src/soc/intel/apollolake/lpc.c M src/soc/intel/apollolake/smihandler.c M src/soc/intel/apollolake/uart.c M src/soc/intel/baytrail/gpio.c M src/soc/intel/baytrail/include/soc/gpio.h M src/soc/intel/baytrail/ramstage.c M src/soc/intel/baytrail/romstage/raminit.c M src/soc/intel/baytrail/romstage/romstage.c M src/soc/intel/baytrail/romstage/uart.c M src/soc/intel/braswell/bootblock/bootblock.c M src/soc/intel/braswell/gpio.c M src/soc/intel/braswell/gpio_support.c M src/soc/intel/braswell/lpc_init.c M src/soc/intel/braswell/ramstage.c M src/soc/intel/braswell/smihandler.c M src/soc/intel/broadwell/gpio.c M src/soc/intel/broadwell/include/soc/gpio.h M src/soc/intel/broadwell/lpc.c M src/soc/intel/broadwell/pcie.c M src/soc/intel/broadwell/pmutil.c M src/soc/intel/broadwell/romstage/romstage.c M src/soc/intel/cannonlake/include/soc/gpio.h M src/soc/intel/cannonlake/pmutil.c M src/soc/intel/common/block/acpi/acpi.c M src/soc/intel/common/block/include/intelblocks/gpio.h M src/soc/intel/common/block/smm/smihandler.c M src/soc/intel/common/block/smm/smitraphandler.c M src/soc/intel/denverton_ns/include/soc/gpio.h M src/soc/intel/fsp_baytrail/bootblock/bootblock.c M src/soc/intel/fsp_baytrail/gpio.c M src/soc/intel/fsp_baytrail/include/soc/gpio.h M src/soc/intel/fsp_baytrail/ramstage.c M src/soc/intel/fsp_baytrail/romstage/romstage.c M src/soc/intel/fsp_baytrail/romstage/uart.c M src/soc/intel/fsp_broadwell_de/gpio.c M src/soc/intel/icelake/include/soc/gpio.h M src/soc/intel/icelake/pmutil.c M src/soc/intel/skylake/include/soc/gpio.h M src/soc/intel/skylake/include/soc/smm.h M src/soc/intel/skylake/pmutil.c M src/soc/intel/skylake/uart.c M src/soc/mediatek/mt8173/gpio.c M src/soc/mediatek/mt8173/gpio_init.c M src/soc/mediatek/mt8173/include/soc/gpio.h M src/soc/mediatek/mt8173/spi.c M src/soc/mediatek/mt8183/gpio.c M src/soc/mediatek/mt8183/include/soc/gpio.h M src/soc/mediatek/mt8183/spi.c M src/soc/qualcomm/ipq40xx/i2c.c M src/soc/qualcomm/ipq40xx/spi.c M src/soc/qualcomm/ipq40xx/uart.c M src/soc/qualcomm/qcs405/blsp.c M src/soc/qualcomm/qcs405/i2c.c M src/soc/qualcomm/qcs405/qup.c M src/soc/qualcomm/qcs405/uart.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/gpio.c M src/soc/rockchip/rk3288/display.c M src/soc/rockchip/rk3288/gpio.c M src/soc/rockchip/rk3288/soc.c M src/soc/rockchip/rk3399/display.c M src/soc/rockchip/rk3399/gpio.c M src/soc/rockchip/rk3399/mipi.c M src/soc/samsung/exynos5250/gpio.c M src/soc/samsung/exynos5250/include/soc/gpio.h M src/soc/samsung/exynos5250/pinmux.c M src/soc/samsung/exynos5250/spi.c M src/soc/samsung/exynos5250/usb.c M src/soc/samsung/exynos5420/gpio.c M src/soc/samsung/exynos5420/include/soc/gpio.h M src/soc/samsung/exynos5420/pinmux.c M src/soc/samsung/exynos5420/usb.c 303 files changed, 273 insertions(+), 289 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/33/34233/12
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/34233 )
Change subject: src: Remove direct 'include <soc/gpio.h>' ......................................................................
Abandoned
-
Angel Pons (Code Review) -
Frans Hendriks (Code Review)
-
HAOUAS Elyes (Code Review)
-
Julius Werner (Code Review)