Attention is currently required from: Sean Rhodes.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67027 )
Change subject: mb/starlabs/starbook/tgl: Use chipset.cb aliases ......................................................................
Patch Set 5:
(3 comments)
Patchset:
PS5: Shouldn't this keep things the same? You could compare the `build/mainboard/*/*/static.c`.
File src/mainboard/starlabs/starbook/variants/tgl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/67027/comment/2d994f38_48b2d1ea PS5, Line 88: device ref north_xhci on Shouldn't this be the PCH one?
https://review.coreboot.org/c/coreboot/+/67027/comment/4c580ebc_417025ec PS5, Line 110: device ref north_xdci on end Why turn it on?
-
Nico Huber (Code Review)