[M] Change in coreboot[main]: soc/mediatek/common: Move I2C functions to common code - coreboot-gerrit

21 Apr 2025


      Attention is currently required from: Hung-Te Lin, Paul Menzel, Vince Liu, Xi Chen, Yu-Ping Wu.
Yidi Lin has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87352?usp=email )
Change subject: soc/mediatek/common: Move I2C functions to common code
......................................................................
Patch Set 5: -Code-Review
(1 comment)
File src/soc/mediatek/common/include/soc/i2c_v1.h:
PS1:
...
How about using the existing `I2C_FAST_SPEED` (i.e. […]
Sounds good. (I was mixed up with I2C_SPEED_STANDARD and I2C_FAST_SPEED).
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/87352?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I6ac7009f5af4e6379d3f73aec61d0f4abd28471c
Gerrit-Change-Number: 87352
Gerrit-PatchSet: 5
Gerrit-Owner: Vince Liu vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Paul Menzel paulepanter@mailbox.org
Gerrit-Reviewer: Xi Chen xixi.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Xi Chen xixi.chen@mediatek.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Vince Liu vince-wl.liu@mediatek.com
Gerrit-Attention: Yu-Ping Wu yupingso@google.com
Gerrit-Comment-Date: Mon, 21 Apr 2025 15:26:23 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Paul Menzel paulepanter@mailbox.org
Comment-In-Reply-To: Vince Liu vince-wl.liu@mediatek.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Comment-In-Reply-To: Yidi Lin yidilin@google.com