Change in coreboot[master]: herobrine: resolve herobrine stanadalone compilation error due to bel...

List overview All Threads
Download

newer

older

Change in coreboot[master]:...

Ravi kumar (Code Review)

29 Oct 2020 29 Oct '20

8:32 p.m.

Ravi kumar has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46976 )

Change subject: herobrine: resolve herobrine stanadalone compilation error due to below upstream changes for trogdor ......................................................................

herobrine: resolve herobrine stanadalone compilation error due to below upstream changes for trogdor

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/1

diff --git a/src/mainboard/google/herobrine/chromeos.fmd b/src/mainboard/google/herobrine/chromeos.fmd index a44a638..0db83ec 100644 --- a/src/mainboard/google/herobrine/chromeos.fmd +++ b/src/mainboard/google/herobrine/chromeos.fmd @@ -11,13 +11,12 @@ RO_FRID 0x100 } RO_VPD(PRESERVE) 228K - RO_DDR_TRAINING(PRESERVE) 8K RO_LIMITS_CFG(PRESERVE) 4K }

RW_VPD(PRESERVE) 32K RW_NVRAM(PRESERVE) 16K - RW_DDR_TRAINING(PRESERVE) 8K + RW_MRC_CACHE(PRESERVE) 8K RW_LIMITS_CFG(PRESERVE) 4K RW_ELOG(PRESERVE) 4K RW_SHARED 4K { diff --git a/src/soc/qualcomm/sc7280/Kconfig b/src/soc/qualcomm/sc7280/Kconfig index fc2f34b..3b1678a 100644 --- a/src/soc/qualcomm/sc7280/Kconfig +++ b/src/soc/qualcomm/sc7280/Kconfig @@ -11,6 +11,7 @@ select HAVE_MONOTONIC_TIMER select ARM64_USE_ARCH_TIMER select SOC_QUALCOMM_COMMON + select CACHE_MRC_SETTINGS

if SOC_QUALCOMM_SC7280

@@ -23,5 +24,6 @@ select VBOOT_RETURN_FROM_VERSTAGE select VBOOT_MUST_REQUEST_DISPLAY select VBOOT_STARTS_IN_BOOTBLOCK + select MRC_CLEAR_NORMAL_CACHE_ON_RECOVERY_RETRAIN

endif

Attachments:

attachment.htm (text/html — 3.7 KB)

Show replies by date

Ravi kumar (Code Review)

1 Nov 1 Nov

6:21 p.m.

New subject: Change in coreboot[master]: herobrine: HACK patch for to resolve herobrine stanadalone compilatio...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#2).

Change subject: herobrine: HACK patch for to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK ......................................................................

herobrine: HACK patch for to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/2

Ravi kumar (Code Review)

3 Nov 3 Nov

1:13 a.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error du...

Hello build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#5).

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 3 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/5

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 5 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

6 Nov 6 Nov

8:31 a.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error du...

Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#8).

HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/8

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 8 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

18 Mar 18 Mar

1:47 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error du...

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#27).

HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/27

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 27 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

4:08 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error du...

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#28).

HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/28

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 28 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

4:25 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error du...

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#29).

HACK herobrine: to resolve herobrine stanadalone compilation error due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/29

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 29 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

mturney mturney (Code Review)

6:11 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Attention is currently required from: Ravi kumar, mturney mturney. mturney mturney has uploaded a new patch set (#30) to the change originally created by Ravi kumar. ( https://review.coreboot.org/c/coreboot/+/46976 )

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error

due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Signed-off-by: T Michael Turney mturney@codeaurora.org --- M src/mainboard/google/herobrine/chromeos.fmd M src/soc/qualcomm/sc7280/Kconfig 2 files changed, 2 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/30

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 30 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

23 Mar 23 Mar

9:28 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#36).

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error

due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/36

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 36 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

10:10 p.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#37).

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error

due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/37

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 37 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

31 Mar 31 Mar

8:42 a.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#44).

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error

due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/44

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 44 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Ravi kumar (Code Review)

17 May 17 May

11:35 a.m.

New subject: Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Attention is currently required from: Ravi kumar, mturney mturney. Hello build bot (Jenkins), mturney mturney,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/46976

to look at the new patch set (#54).

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

HACK herobrine: to resolve herobrine stanadalone compilation error

due to below upstream changes for trogdor HACK

error causing with this trogdor upstream commit: "afaa3d0356d5a518442701875505901e5806bb61" trogdor: Modify DDR training to use mrc_cache

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/76/46976/54

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 54 Gerrit-Owner: Ravi kumar rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney mturney@codeaurora.org Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-Attention: Ravi kumar rbokka@codeaurora.org Gerrit-Attention: mturney mturney mturney@codeaurora.org Gerrit-MessageType: newpatchset

Martin L Roth (Code Review)

7 Aug 7 Aug

11:14 p.m.

New subject: [XS] Change in coreboot[master]: HACK herobrine: to resolve herobrine stanadalone compilation error

Martin L Roth has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/46976?usp=email )

Change subject: HACK herobrine: to resolve herobrine stanadalone compilation error ......................................................................

Abandoned

This patch has not been touched in over 12 months. Anyone who wants to take over work on this patch, please feel free to restore it and do any work needed to get it merged. If you create a new patch based on this work, please credit the original author.

-- To view, visit https://review.coreboot.org/c/coreboot/+/46976?usp=email To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I84552daec00519f856bf3fd19e197ebd2eec54e4 Gerrit-Change-Number: 46976 Gerrit-PatchSet: 64 Gerrit-Owner: Ravi Kumar Bokka rbokka@codeaurora.org Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Reviewer: mturney mturney quic_mturney@quicinc.com Gerrit-CC: Martin L Roth gaumless@gmail.com Gerrit-CC: Paul Menzel paulepanter@mailbox.org Gerrit-MessageType: abandon

547

days inactive

1559

days old

coreboot-gerrit@coreboot.org

12 comments

3 participants

tags (0)

participants (3)

Martin L Roth (Code Review)
mturney mturney (Code Review)
Ravi kumar (Code Review)