Change in coreboot[master]: pci_ids: Drop a block of unused, redundant definitions

[Nico Huber (Code Review)]

Hello Lean Sheng Tan,

I'd like you to do a code review. Please visit

https://review.coreboot.org/c/coreboot/+/34209

to review the following change.

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

pci_ids: Drop a block of unused, redundant definitions

These didn't align with the usual naming conventions and contained some
errors beside.

Change-Id: I45033d4cb998a85fc0bec00c54e207226f42de4e
Signed-off-by: Nico Huber 
---
M src/include/device/pci_ids.h
1 file changed, 0 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34209/1

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index 35c457a..49a890f 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3194,17 +3194,6 @@
 /* Intel EMMC device Ids */
 #define PCI_DEVICE_ID_INTEL_SKL_EMMC		0x9d2b

-/* Intel PCH Ids */
-#define PCH_CNL_LP_M_SUPER			0x9d80
-#define PCH_CNL_LP_M_SUPER_UNLOCK		0x9d81
-#define PCH_CNL_LP_M_SUPER_LOCK			0x9d82
-#define PCH_CNL_LP_Y_PREMIUM			0x9d83
-#define PCH_CNL_LP_U_PREMIUM			0x9d84
-#define PCH_CNL_LP_U_BASE			0x9d85
-#define PCH_CNL_H_DT_SUPER			0xa280
-#define PCH_CNP_H_MOBILE_Q370			0xa306
-#define PCH_CNP_H_MOBILE_QM370			0xa30c
-
 /* Intel WIFI Ids */
 #define PCI_DEVICE_ID_1000_SERIES_WIFI		0x0084
 #define PCI_DEVICE_ID_6005_SERIES_WIFI		0x0085

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG@9 
PS1, Line 9: contained some
           : errors beside.
           : 
whats that ?

https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... 
File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... 
PS1, Line 3198: 
these IDs are not referred anywhere u mean ? like common block PCH code ? or report platform no where ?

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1:

(2 comments)

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG@9 
PS1, Line 9: contained some
           : errors beside.
           :
> whats that ?

At least one of the PCH IDs had MOBILE in the name, but isn't
mobile at all. I didn't try to verify the others.

https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... 
File src/include/device/pci_ids.h:

https://review.coreboot.org/c/coreboot/+/34209/1/src/include/device/pci_ids.... 
PS1, Line 3198:
> these IDs are not referred anywhere u mean ? like common block PCH code ? or report platform no wher […]

See Jenkins' score.

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG@9 
PS1, Line 9: contained some
           : errors beside.
           :
> At least one of the PCH IDs had MOBILE in the name, but isn't […]

it might meant as mobile SKU for handheld device which is okay.

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1: Code-Review+1

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1: Code-Review+2

These IDs are not used anywhere in the tree.

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/34209/1//COMMIT_MSG@9 
PS1, Line 9: contained some
           : errors beside.
           :
> it might meant as mobile SKU for handheld device which is okay.

Why don't you look at it for yourself, it's just two lines
with MOBILE in the name, and pretty obvious what it wrong.

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34209 )

Change subject: pci_ids: Drop a block of unused, redundant definitions
......................................................................

pci_ids: Drop a block of unused, redundant definitions

These didn't align with the usual naming conventions and contained some
errors beside.

Change-Id: I45033d4cb998a85fc0bec00c54e207226f42de4e
Signed-off-by: Nico Huber 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/34209
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Angel Pons 
---
M src/include/device/pci_ids.h
1 file changed, 0 insertions(+), 11 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Angel Pons: Looks good to me, approved

diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h
index ac18aac..0c846c6 100644
--- a/src/include/device/pci_ids.h
+++ b/src/include/device/pci_ids.h
@@ -3196,17 +3196,6 @@
 /* Intel EMMC device Ids */
 #define PCI_DEVICE_ID_INTEL_SKL_EMMC		0x9d2b

-/* Intel PCH Ids */
-#define PCH_CNL_LP_M_SUPER			0x9d80
-#define PCH_CNL_LP_M_SUPER_UNLOCK		0x9d81
-#define PCH_CNL_LP_M_SUPER_LOCK			0x9d82
-#define PCH_CNL_LP_Y_PREMIUM			0x9d83
-#define PCH_CNL_LP_U_PREMIUM			0x9d84
-#define PCH_CNL_LP_U_BASE			0x9d85
-#define PCH_CNL_H_DT_SUPER			0xa280
-#define PCH_CNP_H_MOBILE_Q370			0xa306
-#define PCH_CNP_H_MOBILE_QM370			0xa30c
-
 /* Intel WIFI Ids */
 #define PCI_DEVICE_ID_1000_SERIES_WIFI		0x0084
 #define PCI_DEVICE_ID_6005_SERIES_WIFI		0x0085