Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34867 )
Change subject: intel/denverton_ns: Drop unused save_gpio_route ......................................................................
intel/denverton_ns: Drop unused save_gpio_route
Change-Id: I58131d77ba23024cd23e38584f8062d330d2564f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/soc/intel/denverton_ns/include/soc/smm.h M src/soc/intel/denverton_ns/smm.c 2 files changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/67/34867/1
diff --git a/src/soc/intel/denverton_ns/include/soc/smm.h b/src/soc/intel/denverton_ns/include/soc/smm.h index a020891..182f1c4 100644 --- a/src/soc/intel/denverton_ns/include/soc/smm.h +++ b/src/soc/intel/denverton_ns/include/soc/smm.h @@ -28,7 +28,6 @@ #include <stdint.h> void southcluster_smm_clear_state(void); void southcluster_smm_enable_smi(void); -void southcluster_smm_save_gpio_route(uint32_t route); #endif
#endif /* _DENVERTON_NS_SMM_H_ */ diff --git a/src/soc/intel/denverton_ns/smm.c b/src/soc/intel/denverton_ns/smm.c index 2df6994..fd4f35c 100644 --- a/src/soc/intel/denverton_ns/smm.c +++ b/src/soc/intel/denverton_ns/smm.c @@ -27,12 +27,6 @@ #include <soc/pm.h> #include <soc/smm.h>
-/* Save the gpio route register. The settings are committed from - * southcluster_smm_enable_smi(). */ -static uint32_t gpio_route; - -void southcluster_smm_save_gpio_route(uint32_t route) { gpio_route = route; } - void southcluster_smm_clear_state(void) { uint32_t smi_en;
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34867 )
Change subject: intel/denverton_ns: Drop unused save_gpio_route ......................................................................
Patch Set 1: Code-Review+2
David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34867 )
Change subject: intel/denverton_ns: Drop unused save_gpio_route ......................................................................
Patch Set 1: Code-Review+1
Kyösti Mälkki has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34867 )
Change subject: intel/denverton_ns: Drop unused save_gpio_route ......................................................................
intel/denverton_ns: Drop unused save_gpio_route
Change-Id: I58131d77ba23024cd23e38584f8062d330d2564f Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/34867 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: David Guckian --- M src/soc/intel/denverton_ns/include/soc/smm.h M src/soc/intel/denverton_ns/smm.c 2 files changed, 0 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved David Guckian: Looks good to me, but someone else must approve
diff --git a/src/soc/intel/denverton_ns/include/soc/smm.h b/src/soc/intel/denverton_ns/include/soc/smm.h index a020891..182f1c4 100644 --- a/src/soc/intel/denverton_ns/include/soc/smm.h +++ b/src/soc/intel/denverton_ns/include/soc/smm.h @@ -28,7 +28,6 @@ #include <stdint.h> void southcluster_smm_clear_state(void); void southcluster_smm_enable_smi(void); -void southcluster_smm_save_gpio_route(uint32_t route); #endif
#endif /* _DENVERTON_NS_SMM_H_ */ diff --git a/src/soc/intel/denverton_ns/smm.c b/src/soc/intel/denverton_ns/smm.c index 2df6994..fd4f35c 100644 --- a/src/soc/intel/denverton_ns/smm.c +++ b/src/soc/intel/denverton_ns/smm.c @@ -27,12 +27,6 @@ #include <soc/pm.h> #include <soc/smm.h>
-/* Save the gpio route register. The settings are committed from - * southcluster_smm_enable_smi(). */ -static uint32_t gpio_route; - -void southcluster_smm_save_gpio_route(uint32_t route) { gpio_route = route; } - void southcluster_smm_clear_state(void) { uint32_t smi_en;
-
Angel Pons (Code Review) -
David Guckian (Code Review)
-
Kyösti Mälkki (Code Review)