Attention is currently required from: Arthur Heymans, Philipp Hug, ron minnich.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/81282?usp=email )
Change subject: arch/riscv: reset the pmp on startup
......................................................................
Patch Set 1:
(1 comment)
File src/arch/riscv/virtual_memory.c:
https://review.coreboot.org/c/coreboot/+/81282/comment/e0f7c3d7_2598cb31 :
PS1, Line 50: reset_pmp();
This particular function is safe to run very early. […]
Why don't we clear them directly before setting them (like Philipp suggested). I don't think any function is safe to be called before console output. You never know what the hardware vendor screwed up when initially porting a mainboard. So I don't think we should call this so early if we don't have to.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/81282?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Id356ea66100582d6750ffa9fc01f031a16835e4f
Gerrit-Change-Number: 81282
Gerrit-PatchSet: 1
Gerrit-Owner: ron minnich
rminnich@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: Philipp Hug
philipp@hug.cx
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Arthur Heymans
arthur.heymans@9elements.com
Gerrit-Attention: Philipp Hug
philipp@hug.cx
Gerrit-Attention: ron minnich
rminnich@gmail.com
Gerrit-Comment-Date: Fri, 15 Mar 2024 22:28:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Philipp Hug
philipp@hug.cx
Comment-In-Reply-To: ron minnich
rminnich@gmail.com
Gerrit-MessageType: comment