Attention is currently required from: Derek Huang, Joey Peng, Paul Menzel, Stanley Wu.
Reka Norman has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78146?usp=email )
Change subject: mb/google/dedede/var/boxy: Wait up for 3s for HPD ready signal
......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/dedede/variants/boxy/ramstage.c:
https://review.coreboot.org/c/coreboot/+/78146/comment/784922d5_d8c776a1 :
PS8, Line 69: if (display_init_required()
: && !gpio_get(GPIO_USB_C0_HPD)) {
: /* This has to be done before FSP-S runs. */
: wait_for_hpd(GPIO_USB_C0_HPD, display_timeout_ms);
: } else if (display_init_required()
: && !gpio_get(GPIO_USB_C1_HPD)) {
: /* This has to be done before FSP-S runs. */
: wait_for_hpd(GPIO_USB_C1_HPD, display_timeout_ms);
: }
Done
The code above would still add an unconditional 3s delay when only C1 is connected right? I think it's better to wait for all HPD signals at the same time.
I've uploaded a CL for all dibbi variants here: https://review.coreboot.org/c/coreboot/+/78294. Please test it on boxy.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78146?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I208fdf8234886b2ef43a4b972e6682892238e8e9
Gerrit-Change-Number: 78146
Gerrit-PatchSet: 9
Gerrit-Owner: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Reviewer: Derek Huang
derekhuang@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Leo Chou
leo.chou@lcfc.corp-partner.google.com
Gerrit-CC: Melo Chuang
melo.chuang@lcfc.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Reka Norman
rekanorman@chromium.org
Gerrit-CC: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Attention: Joey Peng
joey.peng@lcfc.corp-partner.google.com
Gerrit-Attention: Derek Huang
derekhuang@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-Comment-Date: Mon, 09 Oct 2023 00:03:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Derek Huang
derekhuang@google.com
Comment-In-Reply-To: Stanley Wu
stanley1.wu@lcfc.corp-partner.google.com
Gerrit-MessageType: comment