Change in coreboot[master]: superio/winbond/w83977tf: Scope UART configuration defines more locally
Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41530 )
Change subject: superio/winbond/w83977tf: Scope UART configuration defines more locally ......................................................................
superio/winbond/w83977tf: Scope UART configuration defines more locally
By undefining the configuration after use we're sure that nobody else comes to depend on it without us noticing.
Change-Id: I7c5cfd58be643d6431989fc69cf3b397920590b9 Signed-off-by: Patrick Georgi pgeorgi@google.com --- M src/superio/winbond/w83977tf/acpi/superio.asl 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/41530/1
diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index 6e37a5b..bd085e1 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -358,6 +358,8 @@ #define SUPERIO_UART_LDN W83977TF_SP2 #define SUPERIO_UART_PM_REG UBPW #include <superio/acpi/pnp_uart.asl> + #undef SUPERIO_UART_LDN + #undef SUPERIO_UART_PM_REG #endif
/*
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41530 )
Change subject: superio/winbond/w83977tf: Scope UART configuration defines more locally ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41530 )
Change subject: superio/winbond/w83977tf: Scope UART configuration defines more locally ......................................................................
superio/winbond/w83977tf: Scope UART configuration defines more locally
By undefining the configuration after use we're sure that nobody else comes to depend on it without us noticing.
Change-Id: I7c5cfd58be643d6431989fc69cf3b397920590b9 Signed-off-by: Patrick Georgi pgeorgi@google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/41530 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/superio/winbond/w83977tf/acpi/superio.asl 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/superio/winbond/w83977tf/acpi/superio.asl b/src/superio/winbond/w83977tf/acpi/superio.asl index 6e37a5b..bd085e1 100644 --- a/src/superio/winbond/w83977tf/acpi/superio.asl +++ b/src/superio/winbond/w83977tf/acpi/superio.asl @@ -358,6 +358,8 @@ #define SUPERIO_UART_LDN W83977TF_SP2 #define SUPERIO_UART_PM_REG UBPW #include <superio/acpi/pnp_uart.asl> + #undef SUPERIO_UART_LDN + #undef SUPERIO_UART_PM_REG #endif
/*
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41530 )
Change subject: superio/winbond/w83977tf: Scope UART configuration defines more locally ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/3626 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3625 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/3624 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/3623
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Patrick Georgi (Code Review)