Attention is currently required from: Hung-Te Lin, Yidi Lin.
Ruihai Zhou has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78957?usp=email )
Change subject: mb/google/geralt: Enable BOE_NV110WUM_L60 panel for Ciri ......................................................................
Patch Set 9:
(1 comment)
File src/mainboard/google/geralt/panel_ciri.c:
https://review.coreboot.org/c/coreboot/+/78957/comment/8291869e_2fc89371 : PS9, Line 17: power_on_mipi_boe_tv110wum_ll0
This function is identical to `power_on_mipi_boe_tv110c9m_ll0` in `panel_geralt.c`. […]
The register PMIC_TPS65132_DLYX is different for power sequence requirment.
In panel.c, add a common power_on_mipi_panel function and define different struct tps65132s_cfg in panel_${BOARD}.c. WDYT?
``` void power_on_mipi_panel(const struct tps65132s_cfg cfg) { mainboard_enable_regulator(MTK_REGULATOR_VDD18, true); mtk_i2c_bus_init(PMIC_TPS65132_I2C, I2C_SPEED_FAST); mdelay(10); if (tps65132s_setup(&cfg) != CB_SUCCESS) printk(BIOS_ERR, "Failed to set up voltage regulator tps65132s\n"); gpio_output(GPIO_DISP_RST_1V8_L, 0); mdelay(1); gpio_output(GPIO_DISP_RST_1V8_L, 1); mdelay(1); gpio_output(GPIO_DISP_RST_1V8_L, 0); mdelay(1); gpio_output(GPIO_DISP_RST_1V8_L, 1); mdelay(6); } ```