Attention is currently required from: Michał Żygowski, Maciej Pijanowski, Christian Walter, Sergii Dmytruk.
Krystian Hebel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68749 )
Change subject: [WIP] util/cbmem: add parsing of TPM logs per standard ......................................................................
Patch Set 2:
(4 comments)
File util/cbmem/cbmem.c:
https://review.coreboot.org/c/coreboot/+/68749/comment/2877789a_64ea403b PS2, Line 902: printf("\tEvent data: %.*s\n", len, log_entry->event); This works only if data is proper text. OTOH Linux does something similar and ends up printing garbage, so we can leave it as is.
https://review.coreboot.org/c/coreboot/+/68749/comment/a5c59a8a_0adff4ff PS2, Line 1037: unmap_memory(&log_mapping); It would be cheaper to map once and cast to proper type.
https://review.coreboot.org/c/coreboot/+/68749/comment/1ec92c18_e17bcb8c PS2, Line 1052: %s Please at least limit the size, we don't know what `signature` points to.
https://review.coreboot.org/c/coreboot/+/68749/comment/681b6614_2ecda3e8 PS2, Line 1054: } Missing `unmap_memory()`.
-
Krystian Hebel (Code Review)