Attention is currently required from: Nick Vaccaro.
Cliff Huang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74841 )
Change subject: soc/intel/common/gpio: Add open-drain GPIO macros ......................................................................
Patch Set 1:
(3 comments)
File src/soc/intel/common/block/gpio/gpio.c:
https://review.coreboot.org/c/coreboot/+/74841/comment/1b1eeb76_4192c81c PS1, Line 724: ~(PAD_CFG0_TX_STATE & PAD_CFG0_TX_DISABLE), Since this change ensures that TX_DISBLE is not set when drive TX output, it can be added to gpio_set(). We don't need to introduce a new function here.
File src/soc/intel/common/block/include/intelblocks/gpio_defs.h:
https://review.coreboot.org/c/coreboot/+/74841/comment/f3bab930_f65fed81 PS1, Line 292: #define PAD_CFG_OD_GPO(pad, rst) \ Since TX is disabled. this can be changed to PAD_CFG_OD()
https://review.coreboot.org/c/coreboot/+/74841/comment/b96b6875_836cc13c PS1, Line 299: #define PAD_CFG_OD_GPO_LOCK(pad, lock_action) \ Since TX is disabled. this can be changed to PAD_CFG_OD_LOCK()
-
Cliff Huang (Code Review)