Change in ...coreboot[master]: mb/kontron/986lcd-m: Use pcidev_on_root()

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

HAOUAS Elyes (Code Review)

23 Jan 2019 23 Jan '19

10:20 a.m.

HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31051

Change subject: mb/kontron/986lcd-m: Use pcidev_on_root() ......................................................................

mb/kontron/986lcd-m: Use pcidev_on_root()

Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/kontron/986lcd-m/mainboard.c 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/31051/1

Attachments:

attachment.htm (text/html — 2.5 KB)

Show replies by date

Kyösti Mälkki (Code Review)

23 Jan 23 Jan

10:27 a.m.

Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/kontron/986lcd-m: Use pcidev_on_root() ......................................................................

Patch Set 1: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 1 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Wed, 23 Jan 2019 13:27:15 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

10:28 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Hello Kyösti Mälkki, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31051

to look at the new patch set (#2).

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

mb/{kontron,supermicro}: Use pcidev_on_root()

Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/supermicro/h8scm_fam10/acpi_tables.c M src/mainboard/supermicro/h8scm_fam10/mptable.c M src/mainboard/supermicro/x10slm-f/mainboard.c 4 files changed, 8 insertions(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/31051/2

Tristan Corrick (Code Review)

24 Jan 24 Jan

6:35 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

Patch Set 2: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/mptable.c:

https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10... PS2, Line 48: pirq_router_bus TODO: why bus_sp5100[0] use same value of : * bus_sr5650[0] assigned by get_pci1234(), instead of 0. This comment is more confusing after the reformatting. I'm not too familiar with the AMD code, but maybe it's better placed near line 44 of h8scm_fam10/get_bus_conf.c

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 09:35:45 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:32 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Hello Kyösti Mälkki, Tristan Corrick, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31051

to look at the new patch set (#3).

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

mb/{kontron,supermicro}: Use pcidev_on_root()

Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/supermicro/h8scm_fam10/acpi_tables.c M src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c M src/mainboard/supermicro/h8scm_fam10/mptable.c M src/mainboard/supermicro/x10slm-f/mainboard.c 5 files changed, 9 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/31051/3

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

HAOUAS Elyes (Code Review)

7:32 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31051/2/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/mptable.c:

...

This comment is more confusing after the reformatting. I'm not too […]

Done

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 2 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 10:32:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tristan Corrick tristan@corrick.kiwi Gerrit-MessageType: comment

Tristan Corrick (Code Review)

7:47 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

Patch Set 3: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/31051/3/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c:

https://review.coreboot.org/#/c/31051/3/src/mainboard/supermicro/h8scm_fam10... PS3, Line 44: bus_sp5100[0] Not necessarily in the scope of this patch, but `bus_sp5100[0]` was replaced with `pirq_router_bus` in CB:30645, so this comment is still a bit confusing.

At this point, I wonder if the comment should even remain.

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 10:47:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:51 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/#/c/31051/3/src/mainboard/supermicro/h8scm_fam10... File src/mainboard/supermicro/h8scm_fam10/get_bus_conf.c:

https://review.coreboot.org/#/c/31051/3/src/mainboard/supermicro/h8scm_fam10... PS3, Line 44: bus_sp5100[0]

...

Not necessarily in the scope of this patch, but `bus_sp5100[0]` was […]

I'll drop it :)

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 3 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 10:51:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Tristan Corrick tristan@corrick.kiwi Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:52 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Hello Kyösti Mälkki, Tristan Corrick, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/31051

to look at the new patch set (#4).

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

mb/{kontron,supermicro}: Use pcidev_on_root()

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/51/31051/4

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: newpatchset

Tristan Corrick (Code Review)

8:05 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Tristan Corrick has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

Patch Set 4: Code-Review+2

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 4 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Thu, 24 Jan 2019 11:05:09 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Patrick Georgi (Code Review)

25 Jan 25 Jan

8:18 a.m.

New subject: Change in ...coreboot[master]: mb/{kontron,supermicro}: Use pcidev_on_root()

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31051 )

Change subject: mb/{kontron,supermicro}: Use pcidev_on_root() ......................................................................

mb/{kontron,supermicro}: Use pcidev_on_root()

Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/31051 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Tristan Corrick tristan@corrick.kiwi --- M src/mainboard/kontron/986lcd-m/mainboard.c M src/mainboard/supermicro/h8scm_fam10/acpi_tables.c M src/mainboard/supermicro/h8scm_fam10/mptable.c M src/mainboard/supermicro/x10slm-f/mainboard.c 4 files changed, 5 insertions(+), 6 deletions(-)

Approvals: build bot (Jenkins): Verified Tristan Corrick: Looks good to me, approved

diff --git a/src/mainboard/kontron/986lcd-m/mainboard.c b/src/mainboard/kontron/986lcd-m/mainboard.c index d0d6c6b..73d5997 100644 --- a/src/mainboard/kontron/986lcd-m/mainboard.c +++ b/src/mainboard/kontron/986lcd-m/mainboard.c @@ -173,7 +173,7 @@ if (!ethernet_disable) continue; printk(BIOS_DEBUG, "Disabling Ethernet NIC #%d\n", i); - dev = dev_find_slot(0, PCI_DEVFN(28, i - 1)); + dev = pcidev_on_root(28, i - 1); if (dev == NULL) { printk(BIOS_ERR, "Disabling Ethernet NIC: Cannot find 00:1c.%d!\n", diff --git a/src/mainboard/supermicro/h8scm_fam10/acpi_tables.c b/src/mainboard/supermicro/h8scm_fam10/acpi_tables.c index 4b2095a..716a77f 100644 --- a/src/mainboard/supermicro/h8scm_fam10/acpi_tables.c +++ b/src/mainboard/supermicro/h8scm_fam10/acpi_tables.c @@ -34,7 +34,7 @@ IO_APIC_ADDR, gsi_base); /* IOAPIC on rs5690 */ gsi_base += 24; /* SB700 has 24 IOAPIC entries. */ - dev = dev_find_slot(0, PCI_DEVFN(0, 0)); + dev = pcidev_on_root(0, 0); if (dev) { pci_write_config32(dev, 0xF8, 0x1); dword = pci_read_config32(dev, 0xFC) & 0xfffffff0; diff --git a/src/mainboard/supermicro/h8scm_fam10/mptable.c b/src/mainboard/supermicro/h8scm_fam10/mptable.c index ca91368..e28f422 100644 --- a/src/mainboard/supermicro/h8scm_fam10/mptable.c +++ b/src/mainboard/supermicro/h8scm_fam10/mptable.c @@ -45,8 +45,7 @@ u32 *dword; u8 byte;

- dev = dev_find_slot(0, //pirq_router_bus TODO: why bus_sp5100[0] use same value of bus_sr5650[0] assigned by get_pci1234(), instead of 0. - PCI_DEVFN(0x14, 0)); + dev = pcidev_on_root(0x14, 0); if (dev) { dword = (u32 *)(pci_read_config32(dev, 0x74) & 0xfffffff0); smp_write_ioapic(mc, apicid_sp5100, 0x11, dword); @@ -79,7 +78,7 @@ * 00:14.6: INTB MCI */ } - dev = dev_find_slot(0, PCI_DEVFN(0, 0)); + dev = pcidev_on_root(0, 0); if (dev) { pci_write_config32(dev, 0xF8, 0x1); dword = (u32 *)(pci_read_config32(dev, 0xFC) & 0xfffffff0); diff --git a/src/mainboard/supermicro/x10slm-f/mainboard.c b/src/mainboard/supermicro/x10slm-f/mainboard.c index 8d0e3b0..4bd5d15 100644 --- a/src/mainboard/supermicro/x10slm-f/mainboard.c +++ b/src/mainboard/supermicro/x10slm-f/mainboard.c @@ -32,7 +32,7 @@ */ static void hide_ast2400(void) { - struct device *dev = dev_find_slot(0, PCI_DEVFN(0x1c, 0)); + struct device *dev = pcidev_on_root(0x1c, 0); if (!dev) return;

-- To view, visit https://review.coreboot.org/c/coreboot/+/31051 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I61b3e5c92830f02d61a108dadde25ff261099e57 Gerrit-Change-Number: 31051 Gerrit-PatchSet: 5 Gerrit-Owner: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Tristan Corrick tristan@corrick.kiwi Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

2277

days inactive

2279

days old

coreboot-gerrit@coreboot.org

10 comments

4 participants

tags (0)

participants (4)

HAOUAS Elyes (Code Review)
Kyösti Mälkki (Code Review)
Patrick Georgi (Code Review)
Tristan Corrick (Code Review)