Attention is currently required from: Felix Held, Fred Reitberger, Jason Glenesk, Matt DeVillier, Raul Rangel.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74993?usp=email )
Change subject: soc/amd/common/data_fabric/domain: write _STA method in SSDT
......................................................................
Patch Set 8:
(1 comment)
Patchset:
PS8:
the domain could be set to off in the devicetree. […]
SSDT wouldn't get generated for an `off` device (non of the device ops
would be called). I guess the original _STA method is just redundant.
Specs says
```
If a device object describes a device that is not on an enumerable
bus and the device object does not have an _STA object, then OSPM
assumes that the device is present, enabled, shown in the UI, and
functioning.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74993?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ied48b48113f6e871e90d17cbd216be003f05b5ef
Gerrit-Change-Number: 74993
Gerrit-PatchSet: 8
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Matt DeVillier
matt.devillier@amd.corp-partner.google.com
Gerrit-Attention: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Fri, 02 Jun 2023 16:23:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment