Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Kun Liu, Nick Vaccaro, Qinghong Zeng.
Subrata Banik has posted comments on this change by Qinghong Zeng. ( https://review.coreboot.org/c/coreboot/+/85844?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/google/brya: Create pujjoniru variant
......................................................................
Patch Set 10:
(3 comments)
File src/mainboard/google/brya/variants/pujjoniru/Makefile.mk:
https://review.coreboot.org/c/coreboot/+/85844/comment/c39e8dc2_09ef108d?usp... :
PS10, Line 2: bootblock-y += gpio.c
please use one empty line between header and next line
File src/mainboard/google/brya/variants/pujjoniru/gpio.c:
https://review.coreboot.org/c/coreboot/+/85844/comment/91386952_ac1a0c78?usp... :
PS10, Line 183:
empty line
File src/mainboard/google/brya/variants/pujjoniru/variant.c:
https://review.coreboot.org/c/coreboot/+/85844/comment/7a5b96a9_ad4c9a7f?usp... :
PS10, Line 17: if (fw_config_probe(FW_CONFIG(WIFI, WIFI_CNVI_WIFI6E)) || fw_config_probe(FW_CONFIG(WIFI, WIFI_UNKNOWN))) {
isn't this line need a line break (> 96 col)?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85844?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I9265d11caad92548c4b33f36b1795ade0b485de0
Gerrit-Change-Number: 85844
Gerrit-PatchSet: 10
Gerrit-Owner: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: hualin wei
weihualin@huaqin.corp-partner.google.com
Gerrit-CC: Cindy Lu
luyi8@huaqin.corp-partner.google.com
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Kun Liu
liukun11@huaqin.corp-partner.google.com
Gerrit-Attention: Qinghong Zeng
zengqinghong@huaqin.corp-partner.google.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 04:21:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No