Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
soc/intel/xeon_sp/skx: Add missing includes
Commit 985d956 (soc/intel/xeon_sp/skx/: Clean up soc_util.c) removed some indirect header inclusions, which resulted in a build failure.
Change-Id: I1ef9b416b52a6a1275d699708a805d4ba49baef0 Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/soc/intel/xeon_sp/skx/chip.c M src/soc/intel/xeon_sp/skx/cpu.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/62/46662/1
diff --git a/src/soc/intel/xeon_sp/skx/chip.c b/src/soc/intel/xeon_sp/skx/chip.c index 845d7cb..4324660 100644 --- a/src/soc/intel/xeon_sp/skx/chip.c +++ b/src/soc/intel/xeon_sp/skx/chip.c @@ -7,6 +7,7 @@ #include <soc/acpi.h> #include <soc/ramstage.h> #include <soc/soc_util.h> +#include <soc/util.h>
struct pci_resource { struct device *dev; diff --git a/src/soc/intel/xeon_sp/skx/cpu.c b/src/soc/intel/xeon_sp/skx/cpu.c index ea9f531..bf712c3 100644 --- a/src/soc/intel/xeon_sp/skx/cpu.c +++ b/src/soc/intel/xeon_sp/skx/cpu.c @@ -9,6 +9,7 @@ #include <soc/msr.h> #include <soc/cpu.h> #include <soc/soc_util.h> +#include <soc/util.h> #include <assert.h> #include "chip.h"
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
ah that's the culprit
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c... File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c... PS1, Line 11: #include <soc/soc_util.h> : #include <soc/util.h> these includes really don't have good names. No wonder stuff like this is happening.
Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c... File src/soc/intel/xeon_sp/skx/cpu.c:
https://review.coreboot.org/c/coreboot/+/46662/1/src/soc/intel/xeon_sp/skx/c... PS1, Line 11: #include <soc/soc_util.h> : #include <soc/util.h>
these includes really don't have good names. No wonder stuff like this is happening.
Done
Stefan Reinauer has submitted this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
soc/intel/xeon_sp/skx: Add missing includes
Commit 985d956 (soc/intel/xeon_sp/skx/: Clean up soc_util.c) removed some indirect header inclusions, which resulted in a build failure.
Change-Id: I1ef9b416b52a6a1275d699708a805d4ba49baef0 Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/46662 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Patrick Georgi pgeorgi@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Stefan Reinauer stefan.reinauer@coreboot.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/xeon_sp/skx/chip.c M src/soc/intel/xeon_sp/skx/cpu.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Stefan Reinauer: Looks good to me, approved Arthur Heymans: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/soc/intel/xeon_sp/skx/chip.c b/src/soc/intel/xeon_sp/skx/chip.c index 845d7cb..4324660 100644 --- a/src/soc/intel/xeon_sp/skx/chip.c +++ b/src/soc/intel/xeon_sp/skx/chip.c @@ -7,6 +7,7 @@ #include <soc/acpi.h> #include <soc/ramstage.h> #include <soc/soc_util.h> +#include <soc/util.h>
struct pci_resource { struct device *dev; diff --git a/src/soc/intel/xeon_sp/skx/cpu.c b/src/soc/intel/xeon_sp/skx/cpu.c index ea9f531..bf712c3 100644 --- a/src/soc/intel/xeon_sp/skx/cpu.c +++ b/src/soc/intel/xeon_sp/skx/cpu.c @@ -9,6 +9,7 @@ #include <soc/msr.h> #include <soc/cpu.h> #include <soc/soc_util.h> +#include <soc/util.h> #include <assert.h> #include "chip.h"
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46662 )
Change subject: soc/intel/xeon_sp/skx: Add missing includes ......................................................................
Patch Set 2:
This was my fault. There was a dependecy on another patch that didn't get merged.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Marc Jones (Code Review)
-
Patrick Georgi (Code Review)
-
Stefan Reinauer (Code Review)
-
Tim Wawrzynczak (Code Review)