build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/27881 )
Change subject: arm64: Turn architectural register accessors into inline functions
......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/#/c/27881/5/src/arch/arm64/include/armv8/arch/li...
File src/arch/arm64/include/armv8/arch/lib_helpers.h:
https://review.coreboot.org/#/c/27881/5/src/arch/arm64/include/armv8/arch/li...
PS5, Line 162: #define MAKE_REGISTER_ACCESSORS_EL123(reg) \
Macros with complex values should be enclosed in parentheses
--
To view, visit
https://review.coreboot.org/27881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I2c41cc3ce49ee26bf12cd34e3d0509d8e61ffc63
Gerrit-Change-Number: 27881
Gerrit-PatchSet: 5
Gerrit-Owner: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 08 Aug 2018 21:25:14 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No