Attention is currently required from: Grace Kao, David Wu.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58566 )
Change subject: mb/google/brya/var/kano: Disable unused PCIE root port in devicetree
......................................................................
Patch Set 2: Code-Review+2
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58566/comment/a307d7be_7574d45e
PS2, Line 7: port
`port`
https://review.coreboot.org/c/coreboot/+/58566/comment/2a8ea416_079bffc2
PS2, Line 8:
: Based on latest schematic to disable PCIE port 6/8/9 (WWAN/SD/SSD).
suggestion:
```
The baseboard enables PCIe RPs 6, 8 and 9, but kano doesn't use
these. Having them enabled will occasionally cause suspend
attempts to fail, therefore disable them in the overridetree.
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/58566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie2b82cff6d910c961eeb56704dcbae2bdc2a8c53
Gerrit-Change-Number: 58566
Gerrit-PatchSet: 2
Gerrit-Owner: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Reviewer: Grace Kao
grace.kao@intel.com
Gerrit-Reviewer: Grace Kao
grace.kao@intel.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Grace Kao
grace.kao@intel.corp-partner.google.com
Gerrit-Attention: David Wu
david_wu@quanta.corp-partner.google.com
Gerrit-Attention: Grace Kao
grace.kao@intel.com
Gerrit-Comment-Date: Mon, 25 Oct 2021 20:12:27 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment