Attention is currently required from: Raul Rangel, Felix Held.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42685 )
Change subject: soc/amd/common: Drop ACPIMMIO bank for SMBus device PCI config
......................................................................
Patch Set 9:
(2 comments)
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42685/comment/e40c7180_c0fd86b5
PS6, Line 60: Help
D14F0 seems to only be for 1.8MHz and configuring legacy UART IO. […]
Ack
File src/soc/amd/picasso/uart.c:
https://review.coreboot.org/c/coreboot/+/42685/comment/674e43f8_1b3beea5
PS8, Line 106: generator divisor programming? 16*115200 = 1.8432M. */
AFAICS one cannot currently select AMD_SOC_UART_1_8MZ anyways with psp_verstage since the register w […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42685
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c8ce8de0a6ab0ed41e7e8a5980d0f0510aaa993
Gerrit-Change-Number: 42685
Gerrit-PatchSet: 9
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Raul Rangel
rrangel@chromium.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Mon, 01 Feb 2021 22:55:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment