Change in ...coreboot[master]: mainboard/google/coral: power off EN_PP3300_DX_LTE_SOC when entering S5 - coreboot-gerrit

28 Jun 2019


      Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/22415 )
Change subject: mainboard/google/coral: power off EN_PP3300_DX_LTE_SOC when entering S5
......................................................................
Patch Set 2:
How do you verify if mainboard_smi_sleep() function is getting called in reboot cycle or not?
we are seeing issue in hatch where modem is asking for PIN in reboot and mainboard_smi_sleep() function can't get call in reboot path. But if we drive required modem GPIO to low in reboot path (somehow) and its working fine, almost similar way how you have done in S5. But problem is that you have added this code inside Sleep handler which won't get called for reboot.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/22415
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie60776d5d9ebc6a69aa9e360bd882f455265dfa2
Gerrit-Change-Number: 22415
Gerrit-PatchSet: 2
Gerrit-Owner: Ben Chan benchan@chromium.org
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Ben Chan benchan@chromium.org
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Subrata Banik subrata.banik@intel.com
Gerrit-Comment-Date: Fri, 28 Jun 2019 05:23:55 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment