Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA support for JSL

[Usha P (Code Review)]

Usha P has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA support for JSL
......................................................................

mb/intel/jasperlake_rvp: Disable SATA support for JSL

This patch disables the SATA config from devicetree for JSL

Change-Id: I9cbcbf96e70b79bfb60f228b77a1065c26cd1aa2
Signed-off-by: Usha P 
---
M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
1 file changed, 1 insertion(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/38996/1

diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
index 843de14..2700a41 100644
--- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
+++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
@@ -66,25 +66,7 @@
    # ClkReq-to-ClkSrc mapping for CLK SRC 0
    register "PcieClkSrcClkReq[0]" = "0x00"

-	register "SataEnable" = "1"
-	register "SataSalpSupport" = "1"
-	register "SataPortsEnable[0]" = "1"
-	register "SataPortsEnable[1]" = "1"
-	register "SataPortsEnable[2]" = "1"
-	register "SataPortsEnable[3]" = "1"
-	register "SataPortsEnable[4]" = "1"
-	register "SataPortsEnable[5]" = "1"
-	register "SataPortsEnable[6]" = "1"
-	register "SataPortsEnable[7]" = "1"
-
-	register "SataPortsDevSlp[0]" = "1"
-	register "SataPortsDevSlp[1]" = "1"
-	register "SataPortsDevSlp[2]" = "1"
-	register "SataPortsDevSlp[3]" = "1"
-	register "SataPortsDevSlp[4]" = "1"
-	register "SataPortsDevSlp[5]" = "1"
-	register "SataPortsDevSlp[6]" = "1"
-	register "SataPortsDevSlp[7]" = "1"
+	register "SataEnable" = "0"

register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA support for JSL
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9 
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
Why? Because there is no such connector?

[Usha P (Code Review)]

Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA support for JSL
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9 
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
> Why? Because there is no such connector?

Since we are not using the SATA controller.

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Usha P (Code Review)]

Hello Karthik Ramasubramanian, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38996

to look at the new patch set (#2).

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

mb/intel/jasperlake_rvp: Disable SATA controller

This patch disables the SATA config from devicetree for JSL

Change-Id: I9cbcbf96e70b79bfb60f228b77a1065c26cd1aa2
Signed-off-by: Usha P 
---
M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
1 file changed, 1 insertion(+), 19 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/38996/2

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 2: Code-Review+2

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Aamir Bohra (Code Review)]

Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/2/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38996/2/src/mainboard/intel/jasperl... 
PS2, Line 241: on  
off

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9 
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
> Since we are not using the SATA controller.

You are not using the SATA controller on the reference board (RVP), that means there are no SATA connectors?

Please extend the commit message.

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Rizwan Qureshi (Code Review)]

Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9 
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
> You are not using the SATA controller on the reference board (RVP), that means there are no SATA con […]

The primary use of the RVP board with coreboot is for chrome. Although the RVP has a SATA port, in the chrome config we are not planning to use SATA storage.

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Usha P (Code Review)]

Hello Karthik Ramasubramanian, Subrata Banik, Aamir Bohra, Rizwan Qureshi, build bot (Jenkins),

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/38996

to look at the new patch set (#3).

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

mb/intel/jasperlake_rvp: Disable SATA controller

This patch disables the SATA config from devicetree for JSL RVP, since we
are not planning to use the SATA storage in chrome config.

Change-Id: I9cbcbf96e70b79bfb60f228b77a1065c26cd1aa2
Signed-off-by: Usha P 
---
M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
1 file changed, 2 insertions(+), 20 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/38996/3

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Usha P (Code Review)]

Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38996/1//COMMIT_MSG@9 
PS1, Line 9: This patch disables the SATA config from devicetree for JSL
> The primary use of the RVP board with coreboot is for chrome. […]

Done

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Usha P (Code Review)]

Usha P has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 3:

(1 comment)

https://review.coreboot.org/c/coreboot/+/38996/2/src/mainboard/intel/jasperl... 
File src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/38996/2/src/mainboard/intel/jasperl... 
PS2, Line 241: on
> off

Done

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 3: Code-Review+1

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[V Sowmya (Code Review)]

V Sowmya has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 3: Code-Review+2

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

mb/intel/jasperlake_rvp: Disable SATA controller

This patch disables the SATA config from devicetree for JSL RVP, since we
are not planning to use the SATA storage in chrome config.

Change-Id: I9cbcbf96e70b79bfb60f228b77a1065c26cd1aa2
Signed-off-by: Usha P 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/38996
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: V Sowmya 
---
M src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
1 file changed, 2 insertions(+), 20 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  V Sowmya: Looks good to me, approved

diff --git a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
index 843de14..9c40f66 100644
--- a/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
+++ b/src/mainboard/intel/jasperlake_rvp/variants/jslrvp/devicetree.cb
@@ -66,25 +66,7 @@
    # ClkReq-to-ClkSrc mapping for CLK SRC 0
    register "PcieClkSrcClkReq[0]" = "0x00"

-	register "SataEnable" = "1"
-	register "SataSalpSupport" = "1"
-	register "SataPortsEnable[0]" = "1"
-	register "SataPortsEnable[1]" = "1"
-	register "SataPortsEnable[2]" = "1"
-	register "SataPortsEnable[3]" = "1"
-	register "SataPortsEnable[4]" = "1"
-	register "SataPortsEnable[5]" = "1"
-	register "SataPortsEnable[6]" = "1"
-	register "SataPortsEnable[7]" = "1"
-
-	register "SataPortsDevSlp[0]" = "1"
-	register "SataPortsDevSlp[1]" = "1"
-	register "SataPortsDevSlp[2]" = "1"
-	register "SataPortsDevSlp[3]" = "1"
-	register "SataPortsDevSlp[4]" = "1"
-	register "SataPortsDevSlp[5]" = "1"
-	register "SataPortsDevSlp[6]" = "1"
-	register "SataPortsDevSlp[7]" = "1"
+	register "SataEnable" = "0"

register "SerialIoI2cMode" = "{
    	[PchSerialIoIndexI2C0]  = PchSerialIoPci,
@@ -256,7 +238,7 @@
    	device pci 16.3 off end # Management Engine KT Redirection
    	device pci 16.4 off end # Management Engine Interface 3
    	device pci 16.5 off end # Management Engine Interface 4
-		device pci 17.0 on  end # SATA
+		device pci 17.0 off end # SATA
    	device pci 19.0 on  end # I2C #4
    	device pci 19.1 off end # I2C #5
    	device pci 19.2 on  end # UART #2

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 4: Code-Review+2

Change in coreboot[master]: mb/intel/jasperlake_rvp: Disable SATA controller

[9elements QA (Code Review)]

9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38996 )

Change subject: mb/intel/jasperlake_rvp: Disable SATA controller
......................................................................

Patch Set 4:

Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3
Emulation targets:
EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/787
EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/786
EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/785

Please note: This test is under development and might not be accurate at all!